Bug 5107 - MARC Editor fails to open Popup in some browsers (IE, Webkit)
Summary: MARC Editor fails to open Popup in some browsers (IE, Webkit)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: rel_3_0
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-10 00:55 UTC by VirtualThinking
Modified: 2012-10-25 23:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix for 3.0.x (49.45 KB, patch)
2010-08-10 14:12 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description VirtualThinking 2010-08-10 00:55:56 UTC
Summary:

(1) Cannot update or edit data in MARC leader and 008 field.
(2) Cannot activate tag editor

Problem:

When editing MARC records the tag editor fails to open in some browsers.  When the tag editor is clicked the following error is generated in IE8.

>>>>>SNIP>>>>>

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0; SLCC1; .NET CLR 2.0.50727; Media Center PC 5.0; .NET CLR 3.5.30729; .NET4.0C; .NET CLR 3.0.30729)
Timestamp: Tue, 10 Aug 2010 00:54:16 UTC


Message: Invalid argument.
Line: 2323
Char: 2
Code: 0
URI: http://173.203.220.32:8080/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=1&op=
Comment 1 Owen Leonard 2010-08-10 12:40:57 UTC
This is the same issue as Bug 2933 (which included patch for 3.0.x) and Bug 3018 (which did not).
Comment 2 Owen Leonard 2010-08-10 14:12:55 UTC
Created attachment 2496 [details] [review]
Proposed fix for 3.0.x

I'll attach this patch here as well since Bug 3018 is already marked as fixed. This patch should do the same for 3.0.x.
Comment 3 VirtualThinking 2010-08-16 02:14:13 UTC
Hi Owen,

The patch applied and fixed the issue, the only issue of note being that the patch threw a slight error on application for 3.0.6:

error: patch failed: cataloguing/value_builder/marc21_field_008_authorities.pl:70
error: cataloguing/value_builder/marc21_field_008_authorities.pl: patch does not apply

Looking over the patch code by hand looked fine to me.  Maybe one of those things.

In the end I had to run git-apply with --reject to get the patch to work and edit the last file by hand.

Thanks!
Comment 4 VirtualThinking 2010-11-24 03:20:07 UTC
Just an additional comment on this issue.  Our users have been testing the newer releases, 3.0.6 and now 3.2.1 and note that this issue seems to be partially resolved by either the diff patch, or by upgrading wholesale to 3.2.1 via current release download.

The [same] issue still seems to persist with the editor with some fields as we are unable to enter data in tag 1xx and 6xx in the cataloguing module.

Would be really good if this could be fully patched in the next bugfix release, or with a patch in the meantime.

Cheers!
Comment 5 Owen Leonard 2010-11-24 13:42:23 UTC
> The [same] issue still seems to persist with the editor with some fields as we
> are unable to enter data in tag 1xx and 6xx in the cataloguing module.

Unable to enter data because the popup won't appear when you try to trigger it, or unable to enter data because you can't type in the input field? If it's the latter, you probably have authorities linked to those tags. You have to click the "..." link to trigger the authority search window.
Comment 6 Owen Leonard 2011-04-18 13:23:48 UTC
Marking this as fixed unless someone can provide an updated report detailing continued problem.