Bug 5137 - Remove obsolete code for counting issues by item type in circulation
Summary: Remove obsolete code for counting issues by item type in circulation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-13 14:04 UTC by Owen Leonard
Modified: 2010-11-30 15:54 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (3.44 KB, patch)
2010-08-13 14:12 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2010-08-13 14:04:14 UTC
circulation.pl contains some obsolete code for counting the number of each item type checked out to the patron. This was a feature in 2.x (or dev_week?) which was never ported to 3.0.
Comment 1 Owen Leonard 2010-08-13 14:12:48 UTC
Created attachment 2521 [details] [review]
Proposed fix

The removed section of code contained a "my $dbh = C4::Context->dbh" which is required for the query of BOR_NOTES. That line has been moved accordingly.
Comment 2 Chris Cormack 2010-11-04 07:53:25 UTC
Patch pushed, please test and close
Comment 3 MJ Ray (software.coop) 2010-11-09 04:17:42 UTC
This bug is mentioned in:
Fix for Bug 5137,	Remove obsolete code counting issues by item type in circ http://lists.koha-community.org/pipermail/koha-patches/2010-October/012756.html
Comment 4 Chris Nighswonger 2010-11-18 03:15:43 UTC
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Comment 5 Chris Nighswonger 2010-11-30 15:54:55 UTC
A fix for this bug has been committed to the current development HEAD as well as released in 3.2.1.