Bug 5157 - borrowers top issuers filters problems
Summary: borrowers top issuers filters problems
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: unspecified
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Henri-Damien LAURENT
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-19 15:00 UTC by Nahuel Angelinetti
Modified: 2012-10-25 23:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch signed-off (4.59 KB, patch)
2011-03-01 20:56 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nahuel Angelinetti 2010-08-19 15:00:04 UTC
There is problems in filters of borrowers top issuers, that doesn't work.
Comment 1 Owen Leonard 2010-08-19 15:03:49 UTC
Please describe what the problems are so that the patch can be properly tested.
Comment 2 Owen Leonard 2011-01-12 15:25:54 UTC
Patch is here: http://lists.koha-community.org/pipermail/koha-patches/2010-August/012450.html. Still don't know what problem it's supposed to fix.
Comment 3 Paul Poulain 2011-03-01 20:55:18 UTC
This patch:
* fixes the report to have it calculated on issuedate not timestamp (timestamp is updated by the check-in)
* adds a "no limit" to the number of displayed result
* removes the "day", "month", "year" that were not working
* removes some commented lines

I've tested the patch, will sign-off, it work correctly
Comment 4 Paul Poulain 2011-03-01 20:56:51 UTC
Created attachment 3231 [details] [review]
patch signed-off
Comment 5 Chris Cormack 2011-03-05 19:32:07 UTC
Pushed, please test and mark resolved