Bug 5162 - patron attributes 'new' link should create blank value
Summary: patron attributes 'new' link should create blank value
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-23 21:10 UTC by Nicole C. Engard
Modified: 2010-12-17 03:21 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (999 bytes, patch)
2010-08-25 14:21 UTC, Owen Leonard
Details | Diff | Splinter Review
follow-up patch (1.24 KB, patch)
2010-10-29 11:43 UTC, Galen Charlton
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2010-08-23 21:10:28 UTC
When adding patron attribute values if you click the 'New' link next to a repeatable attribute it clones the attribute - it should instead create a 'new' blank field for entering data
Comment 1 Owen Leonard 2010-08-25 14:21:08 UTC
Created attachment 2570 [details] [review]
Proposed fix
Comment 2 Galen Charlton 2010-10-29 11:43:03 UTC
Created attachment 2709 [details] [review]
follow-up patch

Fixes problem introduced in original patch where a cloned attribute could not be saved because the hidden input containing the attribute type was cleared.
Comment 3 Chris Cormack 2010-11-02 01:45:02 UTC
Pushed to master, please test and close
Comment 4 MJ Ray (software.coop) 2010-11-15 10:07:29 UTC
This bug is mentioned in:
Fix for Bug 5162,	patron attributes 'new' link should create blank value http://lists.koha-community.org/pipermail/koha-patches/2010-October/012747.html
bug 5162: follow-up patch to not clear	hidden input setting attribute type http://lists.koha-community.org/pipermail/koha-patches/2010-October/012746.html
Comment 5 Chris Nighswonger 2010-11-18 03:15:27 UTC
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Comment 6 Chris Nighswonger 2010-11-30 13:49:34 UTC
This bug has a fix which was committed to the 3.2.x branch and released in 3.2.1.

Please take time to update the status of this bug and mark it RESOLVED FIXED so that it may be closed.