Bug 5175 - The opac XSLTDetails view field Publisher: doesn't provide a hyperlink as the non XSLT view does.
Summary: The opac XSLTDetails view field Publisher: doesn't provide a hyperlink as the...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-25 15:48 UTC by wajasu
Modified: 2010-12-14 18:06 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (3.34 KB, patch)
2010-08-25 16:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Patch with small change to show publisher only once (3.44 KB, patch)
2010-11-12 22:12 UTC, Katrin Fischer
Details | Diff | Splinter Review
sreenshots with broken link (33.25 KB, image/png)
2010-11-20 12:48 UTC, Katrin Fischer
Details
Follow up (2.66 KB, patch)
2010-11-20 13:01 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description wajasu 2010-08-25 15:48:40 UTC
The OPAC XSLT stylesheet normal view (MARC21slim2OPACDetail.xsl) doesn't emit an equivalent hyperlink <a href="/cgi-bin/koha/opac-search.pl?q=pb:<!-- TMPL_VAR NAME="publishercode" ESCAPE="URL" --> ">
just as the non-XSLT normal view does. (Refer to non XSLT code Published by:)

Example==>

Published by :   W.B. Eerdmans Pub. Co.,  (Grand Rapids, Mich. :)

where 
W.B. Eerdmans Pub. Co.,
would be an underlined hyperlink.
Comment 1 Owen Leonard 2010-08-25 16:53:27 UTC Comment hidden (obsolete)
Comment 2 MJ Ray (software.coop) 2010-11-10 08:49:41 UTC
This bug is mentioned in:
Fix for Bug 5175, XSL view doesn't link publisher name to search http://lists.koha-community.org/pipermail/koha-patches/2010-October/012718.html
Comment 3 Katrin Fischer 2010-11-12 20:51:02 UTC
Tested, signed-off and resent.
Comment 4 Katrin Fischer 2010-11-12 22:12:08 UTC
Created attachment 2744 [details] [review]
Patch with small change to show publisher only once

Previous patch was showing publisher twice.
Comment 5 Chris Nighswonger 2010-11-18 03:15:39 UTC
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Comment 6 Katrin Fischer 2010-11-20 12:48:50 UTC
Created attachment 2775 [details]
sreenshots with broken link

If there is no publisher the empty publisher link will break the record display in staff and intranet. Working on a patch.
Comment 7 Katrin Fischer 2010-11-20 13:01:51 UTC
Created attachment 2776 [details] [review]
Follow up

Adds check for subfield b before link is created.
Comment 8 Chris Cormack 2010-11-22 00:50:39 UTC
Follow up patch pushed to master and cherry-picked to 3.2.x please test and resolve (and close if possible)
Comment 9 Katrin Fischer 2010-11-23 11:39:43 UTC
Successfully tested in 3.2.1, will try to check HEAD later.
Comment 10 Chris Nighswonger 2010-11-30 13:49:42 UTC
This bug has a fix which was committed to the 3.2.x branch and released in 3.2.1.

Please take time to update the status of this bug and mark it RESOLVED FIXED so that it may be closed.
Comment 11 MJ Ray (software.coop) 2010-12-09 15:10:54 UTC
This bug is mentioned in:
Fix for Bug 5175,	XSL view doesn't link publisher name to search http://lists.koha-community.org/pipermail/koha-patches/2010-November/012944.html
Fix for Bug 5175, XSL view doesn't link publisher name to search http://lists.koha-community.org/pipermail/koha-patches/2010-November/012949.html
Fix for Bug 5175,	XSL view doesn't link publisher name to search http://lists.koha-community.org/pipermail/koha-patches/2010-November/012950.html
Fix for Bug 5175,	XSL view doesn't link publisher name to search http://lists.koha-community.org/pipermail/koha-patches/2010-November/012951.html
Bug 5175: Publisher link breaks display,	if no publisher exists http://lists.koha-community.org/pipermail/koha-patches/2010-November/013083.html
Comment 12 Katrin Fischer 2010-12-11 06:58:01 UTC
Works in HEAD. Closing bug.