Instead, it should remain as zero, and if the field is made blank, then it should become the default.
As part of this, the whole tax being ignored when creating a vendor thing will be fixed.
Created attachment 2587 [details] [review] proposed patch Still has to go through internal QA.
Created attachment 2592 [details] [review] proposed patch This addresses some issues found in the previous patch.
From the commit message: Bug 5186 - allow tax rates to be set to zero This allows the tax rate for a vendor to be set to zero. Previously, a zero meant that the system default was used. Now, zero means no tax, and to have it be the default the field should simply be left empty. Additionally: * this will now show on the vendor display if the tax value is from the system default * this includes a database update that changes all the existing 0.00 tax settings to be NULL, which preserves existing behaviour. * this now saves the tax value supplied for new vendors * a message is shown telling people what'll happen if a field is left blank * tax is shown on a vendor even if it's zero, for clarity's sake (although all the other tax-related bits aren't)
Created attachment 2886 [details] [review] Rebased form of this patch that applies against v3.02.01 Patch against master coming up...
Created attachment 2887 [details] [review] Patch that applies against master This version applies against master
master signed off (not updating status since I didn't do them both)
Master patch has been pushed to new/bug_5186 but not merged yet, can someone please test and let me know if its working ok.
This bug is mentioned in: Bug 5186 - allow tax rates to be set to zero (master) http://lists.koha-community.org/pipermail/koha-patches/2010-December/013433.html Bug 5186 - allow tax to be set to zero (3.2.1) http://lists.koha-community.org/pipermail/koha-patches/2010-December/013428.html Bug 5186 - allow tax rates to be set to zero (master) http://lists.koha-community.org/pipermail/koha-patches/2010-December/013429.html
Merged to master, please test
This bug is mentioned in: Bug 5186: Follow-up - Fixing wrong database number http://lists.koha-community.org/pipermail/koha-patches/2011-January/013560.html
tested, works as expected