Bug 5213 - Suffix number sequence not resetting properly in hmyymmincr barcode autogen pattern
Summary: Suffix number sequence not resetting properly in hmyymmincr barcode autogen p...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Chris Nighswonger
QA Contact: Bugs List
URL:
Keywords:
: 6093 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-09-09 17:58 UTC by Chris Nighswonger
Modified: 2012-10-25 23:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch (find on second comment) commit on git.koha-community.org 9 Sep 2010 (2.67 KB, patch)
2011-04-05 09:31 UTC, Stéphane Delaune
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Nighswonger 2010-09-09 17:58:10 UTC
Two things are happening.

First, the SELECT does not account for a branchcode greater than 2 chars.

This is fixed by just selecting the final four digits representing the incremental suffix from the barcode field.

Second, the incremental suffix (4 digits) is not rolling back over to zero when reaching 9999.

This pattern probably needs help. It should allow for cataloging of 10000 items per month as is. I would not recommend doing barcode numbering this way, but need to support it since it is in use in at least one library.
Comment 2 Stéphane Delaune 2011-04-05 09:31:49 UTC
Created attachment 3655 [details] [review]
patch (find on second comment) commit on git.koha-community.org 9 Sep 2010
Comment 3 Chris Cormack 2011-04-07 03:44:09 UTC
Pushed, please test
Comment 4 Christophe Croullebois 2011-04-07 13:34:25 UTC
*** Bug 6093 has been marked as a duplicate of this bug. ***