Bug 5214 - undefined itype images cause broken image icon in request.pl
Summary: undefined itype images cause broken image icon in request.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-09 18:14 UTC by Liz Rea
Modified: 2010-11-30 15:54 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (2.46 KB, patch)
2010-09-09 18:34 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Liz Rea 2010-09-09 18:14:10 UTC
If the itemtype images aren't defined, the place hold screen shows broken images (instead of nothing, which would be better).
Comment 1 Owen Leonard 2010-09-09 18:34:18 UTC
Created attachment 2614 [details] [review]
Proposed fix

This looks like a recurrence of Bug 3524, but it's actually a previously undiscovered shortcoming in the fix for that bug. My patch also fixes the same issue on the itemtypes administration page.
Comment 2 Chris Cormack 2010-11-08 02:32:00 UTC
Patch pushed and merged to master, please test master and close
Comment 3 Chris Nighswonger 2010-11-18 03:15:28 UTC
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Comment 4 MJ Ray (software.coop) 2010-11-19 16:35:41 UTC
This bug is mentioned in:
Fix for Bug 5214 -	undefined itype images cause broken image icon in request.pl http://lists.koha-community.org/pipermail/koha-patches/2010-October/012743.html
Comment 5 Chris Nighswonger 2010-11-30 15:54:45 UTC
A fix for this bug has been committed to the current development HEAD as well as released in 3.2.1.