Bug 5236 - "hide my tags" link does nothing
Summary: "hide my tags" link does nothing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL: /cgi-bin/koha/opac-tags.pl?limit=100&...
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-21 13:53 UTC by Owen Leonard
Modified: 2010-11-30 15:54 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (2.09 KB, patch)
2010-09-21 14:14 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2010-09-21 13:53:29 UTC
When viewing tags in the OPAC there is a "hide my tags" link at the top of the page. In the template, if "hidemytags" = 1 the template should hide the table of the user's tags. The script makes no mention of "hidemytags," so clicking the link does nothing.

I propose removing the link since hiding the table of user tags doesn't seem to serve any purpose.
Comment 1 Owen Leonard 2010-09-21 14:14:45 UTC
Created attachment 2636 [details] [review]
Proposed fix
Comment 2 Chris Cormack 2010-11-01 22:16:26 UTC
Pushed and merged to master, please test and close
Comment 3 Chris Cormack 2010-11-08 02:27:55 UTC
Additional patch from Galen pushed and merged as well
Comment 4 MJ Ray (software.coop) 2010-11-15 10:07:11 UTC
This bug is mentioned in:
Fix for Bug 5236 - "hide my	tags" link does nothing http://lists.koha-community.org/pipermail/koha-patches/2010-October/012734.html
bug 5236: remove hidemytags from CSS as	well http://lists.koha-community.org/pipermail/koha-patches/2010-October/012733.html
Comment 5 Chris Nighswonger 2010-11-18 03:15:30 UTC
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Comment 6 Chris Nighswonger 2010-11-30 15:54:47 UTC
A fix for this bug has been committed to the current development HEAD as well as released in 3.2.1.