In 3.2 beta : AuthoritiesMarc.pm fails because of external function call : my ($error, $results, $total_hits)=SimpleSearch( $query, 0, 1, [ "authorityserver" ] ); SimpleSearch is a function of C4/Search.pm so it must be : my ($error, $results, $total_hits) = C4::Search::SimpleSearch( $query, 0, 1, [ "authorityserver" ] ); -- You may see that a correct call is made line 363. Regards.
Created attachment 2644 [details] [review] Proposed patch
Is this happening in 3.2.0? Your proposed patch won't hurt anything, but it shouldn't be necessary since C4::Search exports SimpleSearch by default.
(In reply to comment #2) > Is this happening in 3.2.0? Your proposed patch won't hurt anything, but it > shouldn't be necessary since C4::Search exports SimpleSearch by default. Yes it is present in 3.2.0. When I create a new authority, I have this message : Undefined subroutine &C4::AuthoritiesMarc::SimpleSearch called at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 902. I noticed that the full method is present line 362 : my ($err,$res,$result) = C4::Search::SimpleSearch($query,0,10); So why make it different at line 902 ?
Created attachment 2704 [details] [review] Proposed patch (3.2.0) Updated for 3.2.0
Must be something peculiar to your setup - as I said, works for me. Since, as I also said, it doesn't hurt anything to add 'C4::Search::' to the function call, I've submitted your patch with my signoff. Thanks!
(In reply to comment #5) > Must be something peculiar to your setup - as I said, works for me. Since, as > I also said, it doesn't hurt anything to add 'C4::Search::' to the function > call, I've submitted your patch with my signoff. Thanks! I'm using Debian Squeeze, maybe it's the reason.
Pushed, please test and close
Ok,perfect Link to commit : http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9bd16d23b24d734afa97a047ec66884915544663
This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Closed. End of story.