Bug 5292 - Google Preview Option for OPAC
Summary: Google Preview Option for OPAC
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Darrell Ulm
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-07 18:59 UTC by Darrell Ulm
Modified: 2019-05-04 12:43 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
patch (5.72 KB, patch)
2010-12-16 16:17 UTC, Nicole C. Engard 		Details | Diff | Splinter Review
Bug 5292 - Google Preview Option for OPAC (5.50 KB, patch)
2012-06-09 10:52 UTC, Kyle M Hall 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell Ulm 2010-10-07 18:59:45 UTC 
This Enhancement is for Google Preview option for the OPAC. 

It is separate from Amazon, and so will work with Amazon or other providers.

Darrell Ulm
Comment 1 Darrell Ulm 2010-10-07 19:16:58 UTC 
OK, Patch for new enhancement sent. 

Thanks!

Darrell Ulm
Comment 2 Nicole C. Engard 2010-10-07 23:16:14 UTC 
Darrell,

Where did you send the patch to? I don't see it on the public list or attached here.

Nicole
Comment 3 Darrell Ulm 2010-10-08 13:42:51 UTC 
(In reply to comment #2)
> Darrell,
> 
> Where did you send the patch to? I don't see it on the public list or attached
> here.
> 
> Nicole

Hi Nicole.

I sent it and tested my git send-email on my own account. It was sent to me. 

Is koha-patches@lists.koha-community.org receiving?

  Darrell
Comment 4 Nicole C. Engard 2010-10-08 13:49:39 UTC 
I don't see any patches from you in the patches mailing list - is it possible that you're not registered with the list? I know that was the problem I had the first few patches I thought I sent - they weren't received cause I wasn't a registered user on the list.
Comment 5 Darrell Ulm 2010-10-08 14:32:44 UTC 
(In reply to comment #2)
> Darrell,
> 
> Where did you send the patch to? I don't see it on the public list or attached
> here.
> 
> Nicole

Hi Nicole.

I sent it and tested my git send-email on my own account. It was sent to me. 

Is koha-patches@lists.koha-community.org receiving?

  Darrell(In reply to comment #4)
> I don't see any patches from you in the patches mailing list - is it possible
> that you're not registered with the list? I know that was the problem I had the
> first few patches I thought I sent - they weren't received cause I wasn't a
> registered user on the list.

Nicole, 

OK, well I had better register then. I guess a few patches have been missed.

-Darrell
Comment 6 Darrell Ulm 2010-10-08 15:04:26 UTC 
(In reply to comment #4)
> I don't see any patches from you in the patches mailing list - is it possible
> that you're not registered with the list? I know that was the problem I had the
> first few patches I thought I sent - they weren't received cause I wasn't a
> registered user on the list.

Nicole,

Actually I checked. I am registered and have been. I don't know why it is bouncing. It works when I git send-email to myself. 

I suppose other patches were missed. I have been sending them, but I assume they collected in an email somewhere. 

Weird. I wonder how this can be solved? Any ideas?

-Darrell
Comment 9 Nicole C. Engard 2010-12-16 16:17:56 UTC Comment hidden (obsolete)
Comment 10 Nicole C. Engard 2010-12-16 16:20:11 UTC 
The patch doesn't apply - and it also doesn't have a way to add the preference if you are upgrading (need to update updatedatabase.pl - unless I missed it)


Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y 
Applying Bug 5292 Google Preview Option for OPAC
.dotest/patch:42: trailing whitespace.
   
.dotest/patch:51: trailing whitespace.
      
error: patch failed: installer/data/mysql/en/mandatory/sysprefs.sql:286
error: installer/data/mysql/en/mandatory/sysprefs.sql: patch does not apply
Using index info to reconstruct a base tree...
<stdin>:42: trailing whitespace.
   
<stdin>:51: trailing whitespace.
      
warning: 2 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merged installer/data/mysql/en/mandatory/sysprefs.sql
Auto-merged koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
Auto-merged opac/opac-detail.pl
nengard@debian:~/kohaclone$
Comment 11 Darrell Ulm 2010-12-16 16:34:56 UTC 
(In reply to comment #10)
> The patch doesn't apply - and it also doesn't have a way to add the preference
> if you are upgrading (need to update updatedatabase.pl - unless I missed it)
> 

Yes, I should re-base. I don't think it all got in there. Need to do this next year because of other responsibilities unfortunately.
Comment 12 Kyle M Hall 2012-06-09 10:52:24 UTC 
Created attachment 10010 [details] [review]
Bug 5292 - Google Preview Option for OPAC

Adds option to insert link for Google Books preview into opac for items
with available preview.

Patch based on original work by Darrel Ulm.
Comment 13 Dobrica Pavlinusic 2012-06-09 17:16:53 UTC 
Excuse my ignorance, but in current master we already have Google preview link when using google book covers. Why do we need another implementation of it?
Comment 14 Owen Leonard 2013-05-08 15:12:38 UTC 
(In reply to comment #13)
> Excuse my ignorance, but in current master we already have Google preview
> link when using google book covers. Why do we need another implementation of
> it?

The link we have now opens a new tab/window to the Google Books page. This patch tried to implement this feature for opening an embedded preview within the OPAC:

https://developers.google.com/books/docs/preview-wizard