Bug 5308 - subscriptionroutinglist table is too lax
Summary: subscriptionroutinglist table is too lax
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Srdjan Jankovic
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-14 23:54 UTC by Srdjan Jankovic
Modified: 2012-10-25 23:03 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (2.83 KB, patch)
2010-10-15 00:59 UTC, Robin Sheat
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Srdjan Jankovic 2010-10-14 23:54:53 UTC
subscriptionroutinglist fields borrowernumber and subscriptionid must not be null.
Also, borrowernumber and subscriptionid combination must be unique.
Comment 1 Robin Sheat 2010-10-15 00:59:00 UTC
Created attachment 2689 [details] [review]
Proposed patch
Comment 2 Galen Charlton 2010-11-01 12:08:47 UTC
This could be made even stricter - borrowernumber and subscriptionid ought to have foreign key constraints.
Comment 3 Galen Charlton 2010-11-01 12:26:22 UTC
Submitted pull request for 

git://git.librarypolice.com/git/koha-galen.git bug5308

which includes a sign-off of Srdjan's patch and a follow-up to add the foreign key constraints.
Comment 4 Chris Cormack 2010-11-01 22:04:39 UTC
Pulled into branch new/bug_5308,

If it tests cleanly, will be merged to master, please test and let me know
Comment 5 Chris Cormack 2010-11-03 03:58:30 UTC
Tested ok, pushed to master, please test and close
Comment 6 Chris Nighswonger 2010-11-18 03:15:32 UTC
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Comment 7 MJ Ray (software.coop) 2010-11-19 16:33:15 UTC
This bug is mentioned in:
bug 5308: subscriptionroutinglist more strict http://lists.koha-community.org/pipermail/koha-patches/2010-October/012685.html
Comment 8 Chris Nighswonger 2010-11-30 13:49:37 UTC
This bug has a fix which was committed to the 3.2.x branch and released in 3.2.1.

Please take time to update the status of this bug and mark it RESOLVED FIXED so that it may be closed.