Bug 5312 - XHTML correction in authority summary
Summary: XHTML correction in authority summary
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: 3.8
Hardware: All All
: P3 minor (vote)
Assignee: Fridolin Somers
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-19 07:53 UTC by Fridolin Somers
Modified: 2013-12-05 20:05 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (413 bytes, patch)
2010-10-19 07:54 UTC, Fridolin Somers
Details | Diff | Splinter Review
Proposed patch (updated) (755 bytes, patch)
2011-08-22 13:15 UTC, Fridolin Somers
Details | Diff | Splinter Review
BUG 5312 XHTML correction in authority summary (751 bytes, patch)
2012-06-09 10:10 UTC, Chris Cormack
Details | Diff | Splinter Review
[SIGNED-OFF] BUG5312 XHTML correction in authority summary (823 bytes, patch)
2012-06-09 10:16 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2010-10-19 07:53:21 UTC
When an authority summary contains a "\n",it is replaced by a HTML's "<br>".
XHTML new line is "<br \>".
Comment 1 Fridolin Somers 2010-10-19 07:54:11 UTC Comment hidden (obsolete)
Comment 2 Fridolin Somers 2010-10-19 07:56:50 UTC
(Correction of comment #0)
> When an authority summary contains a "\n",it is replaced by a HTML's "<br>".
> XHTML new line is "<br />".
Patch is correct.
Comment 3 Paul Poulain 2011-08-02 16:00:57 UTC
needs signoff status forgotten, setting it

assigning to Fridolyn, as he sent the patch
Comment 4 Katrin Fischer 2011-08-11 18:01:45 UTC
Change looks good to me but patch is not in a valid format:
Patch format detection failed.

Fridolyn, could you resend as git patch please?
Comment 5 Fridolin Somers 2011-08-22 13:15:25 UTC Comment hidden (obsolete)
Comment 6 Chris Cormack 2012-06-09 10:10:47 UTC Comment hidden (obsolete)
Comment 7 Kyle M Hall 2012-06-09 10:16:11 UTC
Created attachment 9999 [details] [review]
[SIGNED-OFF] BUG5312 XHTML correction in authority summary

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Paul Poulain 2012-06-10 09:16:51 UTC
QA comment: tiny patch that produces valid XHTML, passes QA of course !
Comment 9 Paul Poulain 2012-06-10 09:17:36 UTC
worth porting to 3.8
Comment 10 Fridolin Somers 2012-06-13 08:39:33 UTC
Thanks everyone.

I've learned a bit of XHTML since : new line is "<br/>" (no space).
Patch is correct.
Comment 11 Jared Camins-Esakov 2012-12-31 01:05:28 UTC
There have been no further reports of problems so I am marking this bug resolved.