* The search page will be improved and some fields will be added to search on (issn, subscription number, library, internal note, callnumber) * The subscription list result will be modified. The " will be removed in case of a repeated title & issn (the title & issn will be repeated) * The internal note is not displayed on staff interface. It will be displayed in serial issues and in various places where it can be usefull * An option will be added to limit subscription search by branch
Created attachment 10433 [details] [review] Bug 5357: Adds a new page for searching subscriptions Test plan: - go on the serial module - click on the 'Advanced search' link (right of subscriptions search in the header) - Search subscriptions (by ISSN, title, EAN, Publisher, Supplier and/or Branch) - Check results are correct
ISSN and Bookseller search don't work
Patch tested with a sandbox, by Corinne HAYET <corinne.hayet@bulac.fr>
Created attachment 11263 [details] [review] Bug 5357: Adds a new page for searching subscriptions Test plan: - go on the serial module - click on the 'Advanced search' link (right of subscriptions search in the header) - Search subscriptions (by ISSN, title, EAN, Publisher, Supplier and/or Branch) - Check results are correct Signed-off-by: Corinne HAYET <corinne.hayet@bulac.fr>
Created attachment 11264 [details] [review] Bug 8443: Suggestions publication year and copyright date Signed-off-by: Corinne HAYET <corinne.hayet@bulac.fr>
Created attachment 11265 [details] [review] Bug 8443: Suggestions publication year and copyright date Signed-off-by: Corinne HAYET <corinne.hayet@bulac.fr> http://bugs.koha-community.org/show_bug.cgi?id=5357 Signed-off-by: Corinne HAYET <corinne.hayet@bulac.fr>
Created attachment 11266 [details] [review] Bug 8443: Suggestions publication year and copyright date Signed-off-by: Corinne HAYET <corinne.hayet@bulac.fr> http://bugs.koha-community.org/show_bug.cgi?id=5357 Signed-off-by: Corinne HAYET <corinne.hayet@bulac.fr>
Comment on attachment 11263 [details] [review] Bug 5357: Adds a new page for searching subscriptions unobsoleting this patch, signed-off by Corinne Hayet on camembert sandbox Will obsolete the patch not related to this bug, I made a mistake on my sandbox setup, he made silly things. Should be fixed now
Hi Corinne, was your sign-off on this intended? I see you posted a comment first: "ISSN and Bookseller search don't work" Can you confirm all is ok? Thank you and thanks for testing!
(En réponse au commentaire 12) > Hi Corinne, > was your sign-off on this intended? I see you posted a comment first: > "ISSN and Bookseller search don't work" > Can you confirm all is ok? Thank you and thanks for testing! Hi Katrin, No, it's a mistake :( This patch is not sign-off because ISSN and Bookseller search don't work
so, failing QA (Corinne now knows when to use the 2nd part of the sandbox = only if you want to signoff !)
Created attachment 11287 [details] [review] Bug 5357: Adds a new page for searching subscriptions This patch fixes search for ISSN and bookseller. + removes dead code in serials-home.[pl|tt]
Created attachment 11290 [details] [review] Bug 5357: Adds a new page for searching subscriptions Test plan: - go on the serial module - click on the 'Advanced search' link (right of subscriptions search in the header) - Search subscriptions (by ISSN, title, EAN, Publisher, Supplier and/or Branch) - Check results are correct Signed-off-by: Corinne HAYET <corinne.hayet@bulac.fr>
Hi, I tried giving this another sign-off, but the patch no longer applies. I tried fixing the conflict, but I am not sure how to resolve it. There are recent changes to serials-home that might get undone by adding this patch and moving things into includes (see bug 8432). As this is blocking bug 8415 it would be nice if somoene could take a look.
Created attachment 11736 [details] [review] Bug 5357: Adds a new page for searching subscriptions Test plan: - go on the serial module - click on the 'Advanced search' link (right of subscriptions search in the header) - Search subscriptions (by ISSN, title, EAN, Publisher, Supplier and/or Branch) - Check results are correct
Created attachment 11831 [details] [review] [SIGNED-OFF] Bug 5357: Adds a new page for searching subscriptions Test plan: - go on the serial module - click on the 'Advanced search' link (right of subscriptions search in the header) - Search subscriptions (by ISSN, title, EAN, Publisher, Supplier and/or Branch) - Check results are correct Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 11832 [details] [review] Bug 5357: Follow-up - layout and EAN search 1) EAN search should be hidden if marcflavour is not UNIMARC 2) Fixes layout to match the advanced search in acquisitions - labels in front of the fields instead of separate lines - adds a legend to the form and moves the toggle for the search form to it To test: - EAN search field should only show up when marcflavour system preference is set to UNIMARC - Check layout is consistent and you like it - Check toggle for advanced search still behaves the same
I noticed that the EAN search option was not hidden for MARC21 and some differences in the layout of the form compared to the advance search for acquisitions. I wrote a follow up patch - Jonathan, maybe you can take a look and sign off if it's ok for you? I noticed that the new serials-search.tt file is using 2 spaces for identation. Maybe we should fix that too?
Created attachment 11839 [details] [review] Bug 5357: Follow-up - layout and EAN search 1) EAN search should be hidden if marcflavour is not UNIMARC 2) Fixes layout to match the advanced search in acquisitions - labels in front of the fields instead of separate lines - adds a legend to the form and moves the toggle for the search form to it To test: - EAN search field should only show up when marcflavour system preference is set to UNIMARC - Check layout is consistent and you like it - Check toggle for advanced search still behaves the same Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
(In reply to comment #22) > I noticed that the new serials-search.tt file is using 2 spaces for > identation. Maybe we should fix that too? Hi Katrin, I think there is no coding guidelines for that in the wiki page. For the tt files, if we choose 4 spaces, after the 4 mandatory div (<div id="doc3" class="yui-t2"><div id="bd"><div id="yui-main"><div class="yui-b">), we write each line with 12 spaces. After 3 or 4 blocks, we have a indentation of 24-28 spaces. It's why I prefer to choose only 2 spaces. It could be possible to not indent the 4 first div, but the readabillity would be bad. I am open-minded on this subject especially if a consensus already exists.
(In reply to comment #24) > (In reply to comment #22) > > I noticed that the new serials-search.tt file is using 2 spaces for > > identation. Maybe we should fix that too? > > Hi Katrin, > I think there is no coding guidelines for that in the wiki page. > For the tt files, if we choose 4 spaces, after the 4 mandatory div (<div > id="doc3" class="yui-t2"><div id="bd"><div id="yui-main"><div > class="yui-b">), we write each line with 12 spaces. After 3 or 4 blocks, we > have a indentation of 24-28 spaces. It's why I prefer to choose only 2 > spaces. yes, i completely agree Jonathan! :) lets remember to discuss this sometime on the koha-lists
> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> patches looks good, passing QA… $ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit 2a60d49) * 02e2c00 Bug 5357: Follow-up - layout and EAN search koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt serials/serials-search.pl * 3f31617 Bug 5357: Adds a new page for searching subscriptions C4/Serials.pm koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc koha-tmpl/intranet-tmpl/prog/en/includes/serials-search.inc koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt serials/serials-home.pl serials/serials-search.pl * serials/serials-search.pl OK * C4/Serials.pm OK * serials/serials-home.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt OK * koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc OK * koha-tmpl/intranet-tmpl/prog/en/includes/serials-search.inc OK * koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt OK
Patch pushed to master