On the basket groups page (cgi-bin/koha/acqui/basketgroup.pl?booksellerid=1) there is a button to reopen a basket, but this does not actually reopen the basket in any useful way. Once reopened I cannot edit the contents of the basket, I can only move around baskets in the group and rename the group. There needs to be a way to reopen a basket and a clearer explanation of what the reopen button really does.
If a basket is not part of a basket group, the button to Reopen appears. If a basket is part of a group, there is no button. To reopen a basket belonging to a group, you just first need to "ungroup" it.
(In reply to comment #1) > If a basket is not part of a basket group, the button to Reopen appears. If a > basket is part of a group, there is no button. > To reopen a basket belonging to a group, you just first need to "ungroup" it. Perhaps I'm being dense here, but how does one "ungroup" a basket? Is this in 3.0, 3.2 or only HEAD?
(In reply to comment #2) > (In reply to comment #1) > > If a basket is not part of a basket group, the button to Reopen appears. If a > > basket is part of a group, there is no button. > > To reopen a basket belonging to a group, you just first need to "ungroup" it. > > Perhaps I'm being dense here, but how does one "ungroup" a basket? Is this in > 3.0, 3.2 or only HEAD? In 3.2 : Edit the basket (page /acqui/basket.pl). In combobox "Basket group:", choose "No group". And click on "Change basket group". Hope it helps.
Looks like this applies to 3.0 only. Retagging...
Retagging to master. I think the described problem still exists. It's not clear when the reopen button for baskets will appear and it still requires to 'ungroup' your basket before you can reopen it.
Any suggestions on how we could clarify the situation?
Hm, some ideas: Show the "reopen basket" button, but on clicking it, inform that the basket has to be removed from the basket group first and ask for confirmation for doing this. Show the "reopen basket" button greyed out (possible with buttons?) and display a tooltip of why it won't work yet. Similar to what we do for deleting the record from the detail page with items left. I am not sure how good those ideas are :)
I've just come across this problem when trying to cancel an order in a basket that is within a group, I had to ungroup the basket, then I was able to reopen it and cancel the order. Then regroup the basket. Why can't baskets within basket groups be reopened, edited and closed? What problems would this cause? This is happening in version 18.11.
Created attachment 95092 [details] [review] Bug 5365: Make more clear how to reopen a basket in a basket group The "reopen basket" button will be visible but disabled if the basket cannot be reopened. A tooltip is attached to the button to add more information. Note that the export button is still hidden, would it makes sense to display it (visible and active)? Test plan: - Create a basket - Close it - Go to the basket detail view => The reopen button should be displayed and enabled - Attach it to a basket group - Go to the basket detail view => The reopen button should be displayed but disabled
This patch only addresses what is described in the title of this bug report => Display the button, but disabled, if the basket cannot be reopened.
Created attachment 95106 [details] [review] Bug 5365: Make more clear how to reopen a basket in a basket group The "reopen basket" button will be visible but disabled if the basket cannot be reopened. A tooltip is attached to the button to add more information. Note that the export button is still hidden, would it makes sense to display it (visible and active)? Test plan: - Create a basket - Close it - Go to the basket detail view => The reopen button should be displayed and enabled - Attach it to a basket group - Go to the basket detail view => The reopen button should be displayed but disabled Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This one is in the top 10 of repeated support questions for us, so happy to see this change. We could refine the wording of the tooltip a little bit maybe, but it's ok to go in as is.
Created attachment 95189 [details] [review] Bug 5365: Make more clear how to reopen a basket in a basket group The "reopen basket" button will be visible but disabled if the basket cannot be reopened. A tooltip is attached to the button to add more information. Note that the export button is still hidden, would it makes sense to display it (visible and active)? Test plan: - Create a basket - Close it - Go to the basket detail view => The reopen button should be displayed and enabled - Attach it to a basket group - Go to the basket detail view => The reopen button should be displayed but disabled Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work! Pushed to master for 19.11.00
backported to 19.05.x for 19.05.07
Backported to 18.11.x for 18.11.13