Bug 5381 - Fines in notices prints always 0.00
Summary: Fines in notices prints always 0.00
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) major (vote)
Assignee: Chris Nighswonger
QA Contact: Bugs List
URL:
Keywords:
: 5212 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-11-10 16:20 UTC by Katrin Fischer
Modified: 2010-11-23 17:08 UTC (History)
1 user (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2010-11-10 16:20:47 UTC
The feature for fines in notices produces an error while running  perl /misc/cronjobs/overdue_notices.pl:

Use of uninitialized value $fine in string at /home/koha/kohaclone/misc/cronjobs/overdue_notices.pl line 671.


In the generates messages the fine is always 0.00:

"Tanach - Lehrbuch der jüdischen Bibel " by Liss, Hanna, SZA 37, Barcode: 9979122 Gebühr: €0,00

My notice is using this statement:

<item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Gebühr: <fine>EUR</fine></item>
Comment 1 Chris Nighswonger 2010-11-10 18:15:45 UTC
This was due to passing GetFines a biblionumber rather than an itemnumber.

The patch to fix may be picked up here:

http://git.koha-community.org/gitweb/?p=wip/koha-fbc.git;a=shortlog;h=refs/heads/k_bug_5381
Comment 2 Chris Nighswonger 2010-11-10 18:16:46 UTC
Katrin, If you would not mind, please test, sign-off on, and submit this patch assuming it works ok. tnx
Comment 3 Katrin Fischer 2010-11-12 15:31:45 UTC
Works great, signed-off and sent to patches list.
Comment 4 Katrin Fischer 2010-11-15 07:03:30 UTC
Successfully tested on current HEAD.
Comment 5 Chris Nighswonger 2010-11-18 03:15:35 UTC
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Comment 6 Ian Walls 2010-11-23 17:08:40 UTC
*** Bug 5212 has been marked as a duplicate of this bug. ***