Bug 5386 - t/00-load.t adds unnecessary dependency to Path::Class
Summary: t/00-load.t adds unnecessary dependency to Path::Class
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-11 13:29 UTC by Galen Charlton
Modified: 2012-10-25 23:03 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2010-11-11 13:29:09 UTC
File::Spec can do the directory munging just as well and is a core module.  Path::Class looks like a fine module, but adding the dependency isn't worth it for just one test case.
Comment 1 Chris Cormack 2010-11-12 02:47:20 UTC
Patch pushed, please test and close
Comment 2 MJ Ray (software.coop) 2010-12-14 10:21:43 UTC
This bug is mentioned in:
bug 5386: remove dep on Path::Class from	t/00-load.t http://lists.koha-community.org/pipermail/koha-patches/2010-November/012902.html
bug 5386: remove dep on Path::Class from	t/00-load.t http://lists.koha-community.org/pipermail/koha-patches/2010-November/012912.html