Bug 5399 - remove useless eval 'use C4::Foo'
Summary: remove useless eval 'use C4::Foo'
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) trivial (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-13 04:53 UTC by Galen Charlton
Modified: 2012-10-25 23:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2010-11-13 04:53:57 UTC
A couple scripts use constructs like this:

eval "use C4::Acquisition qw/GetBasket/;";

I can think of no good reason to do this for standard C4 modules, especially since the code never checked to see if the eval succeeded.
Comment 1 MJ Ray (software.coop) 2010-12-12 19:16:15 UTC
This bug is mentioned in:
bug 5399: remove useless eval 'use C4::Foo' http://lists.koha-community.org/pipermail/koha-patches/2010-November/012966.html
Comment 2 Marcel de Rooy 2011-01-17 09:17:40 UTC
Signed patch (updated for current master)
Comment 3 Chris Cormack 2011-01-17 10:01:51 UTC
Patch, and follow up patch pushed

Would still like to see a fix to the use $pdfformat bit
Comment 4 MJ Ray (software.coop) 2011-02-05 19:00:54 UTC
This bug is mentioned in:
Bug 5399: remove useless eval	'use C4::Foo' http://lists.koha-community.org/pipermail/koha-patches/2011-January/013608.html
Bug 5399: remove useless eval 'use C4::Foo' http://lists.koha-community.org/pipermail/koha-patches/2011-January/013609.html