Bug 5402 - "add to cart" shown on checkbox hover even if cart disabled
Summary: "add to cart" shown on checkbox hover even if cart disabled
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-13 17:46 UTC by Ian Walls
Modified: 2012-10-25 22:52 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (3.00 KB, patch)
2010-11-24 14:33 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Walls 2010-11-13 17:46:21 UTC
On the OPAC search results page, when hovering over the checkbox next to each results "add to cart" is displayed in any of these three cases:

1. opacbookbag is on
2. virtualshelves is on
3. RequestonOPAC is on

The message only makes sense in the first case, and should be different for the other two.  The title attribute of the input should change depending on what system preferences are enabled and disabled.
Comment 1 Owen Leonard 2010-11-24 14:33:07 UTC
Created attachment 2782 [details] [review]
Proposed fix

This patch removes the title hint altogether. The checkbox might be used for the cart, lists, holds, or tags, and expressing this in a title hint seems overly complicated.
Comment 2 Chris Cormack 2010-11-30 21:31:46 UTC
Patches pushed to master please test
Comment 3 Ian Walls 2010-11-30 21:33:54 UTC
Tested.  This patch resolves the bug.  Closing ticket.