Bug 5403 - C4::Koha::DisplayISBN should be wrapper for Business::ISBN->as_string
Summary: C4::Koha::DisplayISBN should be wrapper for Business::ISBN->as_string
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-14 03:17 UTC by Galen Charlton
Modified: 2012-10-25 23:03 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2010-11-14 03:17:49 UTC
Now that Koha uses Business::ISBN, the handcrafted code for generating a display version of an ISBN should no longer be necessary -- DisplayISBN can just be a wrapper for Business::ISBN.
Comment 1 Colin Campbell 2010-12-13 18:26:55 UTC
Actually the only place where DisplayISBN is used is in C4/Biblio to retrieve a publisher code. Therefore the routine (which did generate some oddly formatted iscns!) could be removed if Biblio uses Business::ISBN directly
Comment 2 Colin Campbell 2010-12-14 09:31:14 UTC
Actually The calling routine GetPublisherNameFromIsbn is not used either. Sent patch to remove both routines
Comment 3 MJ Ray (software.coop) 2011-01-05 23:21:48 UTC
This bug is mentioned in:
Bug 5403 Remove DisplayISBN and	GetPublisherNameFromIsbn http://lists.koha-community.org/pipermail/koha-patches/2010-December/013268.html
Comment 4 Chris Cormack 2011-01-17 06:46:56 UTC
Pushed, please test

NOTE this will break some unit tests, that is ok, I have purposefully done so so that I can use it for a teaching tool with my students tomorrow.