Bug 5409 - Call number is not show on Opac search result page.
Summary: Call number is not show on Opac search result page.
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low normal
Assignee: Meenakshi
QA Contact: Mason James
URL:
Keywords:
: 4268 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-11-15 10:40 UTC by Amit Gupta
Modified: 2015-10-19 22:05 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
[PATCH] Bug 5409 - Fix call number not shown on opac search result page (1.10 KB, patch)
2010-11-15 10:54 UTC, Amit Gupta
Details | Diff | Splinter Review
Attaching Patch. (1.71 KB, patch)
2012-06-15 05:49 UTC, Meenakshi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 5409 - Fix call number not shown on opac search result page (1.13 KB, patch)
2012-07-20 14:38 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 5409 [2] Call number is not show on Opac search result page. (1.83 KB, patch)
2012-07-20 14:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Attaching the latest patch. (3.26 KB, patch)
2012-09-18 10:21 UTC, Meenakshi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 5409 - Fix call number not shown on opac search result page (1.17 KB, patch)
2012-09-21 13:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 5409 - Call number is not show on Opac search result page. (1.89 KB, patch)
2012-09-21 13:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 5409 - Call number is not show on Opac search result page - QA Followup (2.61 KB, patch)
2012-09-21 13:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Amit Gupta 2010-11-15 10:40:07 UTC
Call number is not shown on opac search result page while system preference OPACItemsResultsDisplay is on.
Comment 1 Amit Gupta 2010-11-15 10:54:18 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2010-11-15 12:52:20 UTC
There is a conflict in the definition of the syspref.  The SQL files install it as type choice with the possible values being 'statuses' and 'itemdetails'.  The description is

statuses : show only the status of items in result list. itemdisplay : show full location of items (branch+location+callnumber) as in staff interface

However, preferences/searching.pref thinks that it's a Boolean:

           - pref: OPACItemsResultsDisplay
              type: boolean
              choices:
                  yes: Show
                  no: "Don't show"

Since there are only two choices, even in the original definition of the system preference, the (what I suspect was inadvertent) redefinition of it in searching.pref needs a corresponding database update that would do the following:

* change the type of the syspref to YesNo
* set the syspref value to '1' if it is 'itemdetails' and 0 if it is 'statuses', leaving it alone if it is already 1 or 0.
Comment 3 Owen Leonard 2010-11-15 13:26:11 UTC
I submitted a patch for Bug 4268 which I hoped would solve the OPACItemsResultsDisplay problem.
Comment 4 Owen Leonard 2010-11-15 13:27:03 UTC
> I submitted a patch for Bug 4268 which I hoped would solve the
> OPACItemsResultsDisplay problem.

I guess my solution and Amit's were the same, and both incorrect?
Comment 5 MJ Ray (software.coop) 2010-12-09 15:11:01 UTC
This bug is mentioned in:
Bug 5409 - Fix call number not shown on opac	search result page http://lists.koha-community.org/pipermail/koha-patches/2010-November/013009.html
Comment 6 Meenakshi 2012-06-15 05:49:34 UTC Comment hidden (obsolete)
Comment 7 Chris Cormack 2012-06-24 07:21:07 UTC
I think both these patches are needed, unobsoleting one
Comment 8 Owen Leonard 2012-07-20 14:38:59 UTC Comment hidden (obsolete)
Comment 9 Owen Leonard 2012-07-20 14:43:05 UTC Comment hidden (obsolete)
Comment 10 Owen Leonard 2012-07-20 14:43:55 UTC
These patches correct the problem for the "normal" view in the OPAC. It does not affect the XSLT display.
Comment 11 Jonathan Druart 2012-07-23 13:15:11 UTC
QA Comments:
Display the location and itemcallnumber for items if the syspref OPACItemsResultsDisplay is on.

Marking as Passed QA
Comment 12 Paul Poulain 2012-07-24 15:02:11 UTC
QA comment:

I think this patch is wrong because OPACItemsResultsDisplay is not updated to boolean everywhere:

installer/data/mysql/sysprefs.sql still says

INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('OPACItemsResultsDisplay',"statuses",'statuses : show only the status of items in result list. itemdisplay : show full lo
cation of items (branch+location+callnumber) as in staff interface',"statuses|itemdetails",'Choice');

I think other places are OK.
Please provite an other follow-up & switch back to passed QA, i'll push
Comment 13 Meenakshi 2012-09-18 10:21:56 UTC Comment hidden (obsolete)
Comment 14 Kyle M Hall (khall) 2012-09-21 13:08:45 UTC
Created attachment 12425 [details] [review]
[SIGNED-OFF] Bug 5409 - Fix call number not shown on opac search result page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 15 Kyle M Hall (khall) 2012-09-21 13:09:12 UTC
Created attachment 12426 [details] [review]
[SIGNED-OFF] Bug 5409 - Call number is not show on Opac search result page.

Fixes Bug 5409, Set the syspref value to 1 if it is itemdetails and 0 if it
is statuses, leaving it alone if it is already 1 or 0 and change the type
of the syspref to YesNo.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 16 Kyle M Hall (khall) 2012-09-21 13:11:04 UTC
Created attachment 12427 [details] [review]
[SIGNED-OFF] Bug 5409 - Call number is not show on Opac search result page - QA Followup

Fixes Bug 5409, Modified the definition of  'OPACItemsResultsDisplay' in systempreferences and changed the code in opac-search.pl file for 'OPACItemsResultsDisplay'.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 17 Mason James 2012-10-04 01:15:39 UTC
(In reply to comment #16)
> Created attachment 12427 [details] [review]
> [SIGNED-OFF] Bug 5409 - Call number is not show on Opac search result page -
> QA Followup
> 
> Fixes Bug 5409, Modified the definition of  'OPACItemsResultsDisplay' in
> systempreferences and changed the code in opac-search.pl file for
> 'OPACItemsResultsDisplay'.
> 
> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

patch works as expected, passing QA on 3 patches...

$ koha-qa.pl -c 3

testing 3 commit(s) (applied to commit 6c18204)
 * bff8bed Bug 5409 - Call number is not show on Opac search result page.
      installer/data/mysql/sysprefs.sql

 * 350b661 Bug 5409 - Call number is not show on Opac search result page.
      installer/data/mysql/updatedatabase.pl

 * e9be52e Bug 5409 - Fix call number not shown on opac search result page
      opac/opac-search.pl

* installer/data/mysql/updatedatabase.pl                                   OK
* opac/opac-search.pl                                                      OK
Comment 18 Paul Poulain 2012-10-08 15:03:07 UTC
Patch pushed to master
Comment 19 Chris Cormack 2013-04-24 07:37:55 UTC
Was pushed to 3.10.x
Comment 20 Mark Tompsett 2015-10-19 22:05:35 UTC
*** Bug 4268 has been marked as a duplicate of this bug. ***