Bug 5417 - System Preference page for itemBarcodeInputFilter text is "scanned patron barcodes."
Summary: System Preference page for itemBarcodeInputFilter text is "scanned patron bar...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: unspecified
Hardware: All All
: PATCH-Sent (DO NOT USE) minor
Assignee: Paul Poulain
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-17 15:47 UTC by Koustubha Kale
Modified: 2012-10-25 23:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
itemBarcodeInputFilter system preference page text change (1.26 KB, patch)
2010-11-17 16:18 UTC, Koustubha Kale
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Koustubha Kale 2010-11-17 15:47:06 UTC
Since itemBarcodeInputFilter setting does not affect Patron Barcodes at all, the text "scanned patron barcodes." on the system preference settings page for circulation needs to be changed to something more accurate.
Comment 1 Koustubha Kale 2010-11-17 16:18:36 UTC
Created attachment 2769 [details] [review]
itemBarcodeInputFilter system preference page text change

The text describing the itemBarcodeInputFilter system preference changed from "scanned patron barcodes." to "scanned item barcodes."
Comment 2 MJ Ray (software.coop) 2010-12-12 19:16:26 UTC
This bug is mentioned in:
Bug 5417: itemBarcodeInputFilter text change http://lists.koha-community.org/pipermail/koha-patches/2010-November/013056.html
Comment 3 Paul Poulain 2011-03-01 21:03:52 UTC
Nicole, i've assigned it to you. It's a one patch line, related to sysprefs.

It works, but i can't confirm it is functionnaly correct. Pls check, it should be easy for you
Comment 4 Nicole C. Engard 2011-03-01 21:22:29 UTC
I'm reassigning the patch to the developer (like is the standard).  I'll test it when I get a chance.
Comment 5 Nicole C. Engard 2011-03-01 21:33:07 UTC
It does not apply:


Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: Bug 5417: itemBarcodeInputFilter text change
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
Failed to merge in the changes.
Patch failed at 0001 Bug 5417: itemBarcodeInputFilter text change
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
nengard@debian:~/kohaclone$
Comment 6 Koustubha Kale 2011-03-03 05:36:52 UTC
The patch for bug 5418 submitted by me has resolved this bug. And I think that patch has made it to master. 
If someone could verify with a recent git install if the text description of itemBarcodeInputFilter syspref shows "scanned item barcodes", we could squash this bug.
Comment 7 Nicole C. Engard 2011-03-04 00:06:48 UTC
you are correct. this is fixed.