There are structural differences between borrowers and deletedborrowers. - cardnumber varchar(16) vs. varchar(9) - privacy column is missing from deletedborrowers koha-error-log message after successfully(!) deleting a borrower: [Sun Nov 21 01:57:45 2010] [error] [client ::1] [Sun Nov 21 01:57:45 2010] deletemem.pl: DBD::mysql::st execute failed: Column count doesn't match value count at row 1 at /home/katrin/kohaclone/C4/Members.pm line 1610., referer: http://localhost:8080/cgi-bin/koha/members/moremember.pl?borrowernumber=5 The data of the deleted borrower is not saved to the table deletedborrowers. I am going to send a patch to update the database and resolve the differences between the tables.
Created attachment 2777 [details] [review] Proposed patch, written for and tested with HEAD Problem exists in 3.2 and HEAD.
Created attachment 2778 [details] [review] Proposed patch, written for and tested with 3.2.x
Created attachment 2802 [details] [review] Patch for 3.2 Rebased to current HEAD.
Created attachment 2804 [details] [review] Revised patch. Slightly revised patch for 3.2 and HEAD - signed off by Koustubha Kale.
Works as promised. Tested with HEAD On Mon, Dec 6, 2010 at 12:58 PM, Katrin Fischer wrote: > Should also apply to 3.2.x ( Not tested with 3.2.x)
This bug is mentioned in: Bug 5423: Deleted Patrons are no longer saved in table deletedborrowers http://lists.koha-community.org/pipermail/koha-patches/2010-November/013084.html Bug 5423: Deleted Patrons are no longer saved in table deletedborrowers http://lists.koha-community.org/pipermail/koha-patches/2010-November/013085.html
Pushed to master please test
Works in HEAD. Leaving bug open until pushed and tested in 3.2.1.
Applied to HEAD, fixed a small error in template, signed-off and resent.
Too many tabs... ignore previous comment.
I do have a privacy column in my deleted borrowers table (in HEAD) and I have no errors in my log on deleting a patron. Here's my table: mysql> select * from deletedborrowers; +----------------+----------------+---------+-----------+-------+------------+----------+--------------+------------+------------------+----------+-----------------+---------+---------+-------+----------------+--------+------+----------+----------+----------------+--------------+-----------+------------+--------+-----------+-----------+---------+---------+-------------+------------+--------------+--------------+------------+---------------+------+----------+-------------+------------------+--------------+-------------+---------------+--------------+-----------+----------+------+------------------+-------+----------------+----------+-------------+------------------+-------+---------------------+-------------------+--------------------+--------------------+--------------------+-------------------+-------------------+-----------------+----------------+---------+ | borrowernumber | cardnumber | surname | firstname | title | othernames | initials | streetnumber | streettype | address | address2 | city | zipcode | country | email | phone | mobile | fax | emailpro | phonepro | B_streetnumber | B_streettype | B_address | B_address2 | B_city | B_zipcode | B_country | B_email | B_phone | dateofbirth | branchcode | categorycode | dateenrolled | dateexpiry | gonenoaddress | lost | debarred | contactname | contactfirstname | contacttitle | guarantorid | borrowernotes | relationship | ethnicity | ethnotes | sex | password | flags | userid | opacnote | contactnote | sort1 | sort2 | altcontactfirstname | altcontactsurname | altcontactaddress1 | altcontactaddress2 | altcontactaddress3 | altcontactzipcode | altcontactcountry | altcontactphone | smsalertnumber | privacy | +----------------+----------------+---------+-----------+-------+------------+----------+--------------+------------+------------------+----------+-----------------+---------+---------+-------+----------------+--------+------+----------+----------+----------------+--------------+-----------+------------+--------+-----------+-----------+---------+---------+-------------+------------+--------------+--------------+------------+---------------+------+----------+-------------+------------------+--------------+-------------+---------------+--------------+-----------+----------+------+------------------+-------+----------------+----------+-------------+------------------+-------+---------------------+-------------------+--------------------+--------------------+--------------------+-------------------+-------------------+-----------------+----------------+---------+ | 37 | 23529000197047 | Charles | Lisa | | | | NULL | NULL | 5129 Library Rd. | NULL | Centerville, CA | 44262 | NULL | NULL | (212) 555-1212 | NULL | NULL | NULL | NULL | NULL | NULL | | NULL | | | NULL | | | 1982-10-14 | MPL | K | 1988-11-14 | 2020-12-31 | 0 | 0 | 0 | Alford | Jordan | NULL | 45 | | father | NULL | NULL | M | 42b29d0771f3b7ef | NULL | 23529000197047 | | | 0.26352253767058 | Y | | | | | | | NULL | | NULL | 1 | 1 row in set (0.00 sec)
oops we all missed that the patch has been pushed :) ignore my notes
This bug is mentioned in: Bug 5423: Deleted Patrons are no longer saved in table deletedborrowers http://lists.koha-community.org/pipermail/koha-patches/2010-December/013168.html
Successfully tested on master and 3.2.x with fresh databases.