If the proposed changes for Bug 5422 are accepted, the same change should be made to the way cities are stored. The JavaScript in the template for members/memberentry.pl for automatically filling the city and zip fields will have to be modified to do the state as well.
It looks like the proposed changes for 5422 have been accepted--in 3.4 there is now a State field in the Add/Edit Patron form. However, the JavaScript in the form still puts the value for the State in the City field.
Currently if you add a city, you must also add a zip code. There is JavaScript validation which asks you to fill in both. Should state also be required? I would answer yes for US libraries. How about elsewhere?
"No" for Norwegian libraries. We only use city and zip, not state.
Created attachment 4728 [details] [review] Proposed fix - Updates cities management (admin/cities.pl) to record a separate state and country field. - Updates the cities table with these new columns - Modifies the patron entry form to populate city, state, zip and country when the user chooses a prepopulated city entry
Created attachment 4825 [details] [review] proposed patch (passed QA)
Created attachment 4826 [details] [review] proposed patch follow-up (passed QA) QA comment The patch did not include the kohastructure.sql to reflect the updatedatabase. Fixing this mistake Otherwise, no specific comment: easy to test, cleanly written, do what it was supposed to do, no side effect detected
Created attachment 4827 [details] [review] proposed patch follow-up 2 version bumping (passed QA)
Pushed, please test