Bug 5457 - gather_print_notices.pl requires explicit stylesheet
Summary: gather_print_notices.pl requires explicit stylesheet
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Ian Walls
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-30 15:50 UTC by Ian Walls
Modified: 2012-10-25 22:53 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
signed off patch (1.30 KB, patch)
2010-12-06 14:28 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Walls 2010-11-30 15:50:50 UTC
The cronjob script gather_print_notices.pl can take an optional stylesheet for the HTML output with the -s flag.  However, the code does not perform any sort of check to see if a stylesheet is actually declared before it attempts to open, and will return errors if no stylesheet is passed to the script.
Comment 1 Nicole C. Engard 2010-12-06 14:27:19 UTC
patch signed off
Comment 2 Nicole C. Engard 2010-12-06 14:28:17 UTC
Created attachment 2807 [details] [review]
signed off patch
Comment 3 Chris Cormack 2010-12-06 20:05:09 UTC
Patch pushed, please test
Comment 4 Ian Walls 2010-12-10 12:53:49 UTC
Tested.  Closing.