Bug 5466 - Allow currency to be set during order creation
Summary: Allow currency to be set during order creation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement
Assignee: Henri-Damien LAURENT
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-02 15:13 UTC by Savitra Sirohi
Modified: 2012-10-25 23:03 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Patch against master, introduces currency drop down list in order screen (7.69 KB, patch)
2010-12-04 07:54 UTC, Savitra Sirohi
Details | Diff | Splinter Review
Path to default order currency to that in vendor record (2.63 KB, patch)
2010-12-09 16:08 UTC, Colin Campbell
Details | Diff | Splinter Review
Original patch rebased (7.54 KB, patch)
2011-03-18 13:59 UTC, Colin Campbell
Details | Diff | Splinter Review
Rebased patch (2.63 KB, patch)
2011-03-18 14:00 UTC, Colin Campbell
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Savitra Sirohi 2010-12-02 15:13:01 UTC
A currency drop down list is made availabe in the order screen. Corressponding exchange rate is used to calcuate the totals in the active currency.
Comment 2 Katrin Fischer 2010-12-04 05:08:52 UTC
Hi, 
can you please attach the patch file to the bug? It makes testing a lot easier for me. Thank you!
Comment 3 Savitra Sirohi 2010-12-04 07:54:12 UTC Comment hidden (obsolete)
Comment 4 Colin Campbell 2010-12-09 16:04:50 UTC
There is a flaw in the patch. When creating a new order the vendor currency is ignored and the user has to select it. This is probably not what the user wants in almost all cases. Will attach a patch rectifying this.
Comment 5 Colin Campbell 2010-12-09 16:08:55 UTC Comment hidden (obsolete)
Comment 6 MJ Ray (software.coop) 2011-01-05 23:21:36 UTC
This bug is mentioned in:
Acquisitions - ability to set currency in order screens - Bug 5466 http://lists.koha-community.org/pipermail/koha-patches/2010-December/013147.html
Comment 7 Julian Maurice 2011-03-18 13:30:04 UTC
Patch does not apply.
--
Applying: Acquisitions - ability to set currency in order screens
/home/julian/koha/versions/koha-community-git/.git/rebase-apply/patch:22: trailing whitespace.
   
error: patch failed: acqui/basket.pl:217
error: acqui/basket.pl: patch does not apply
Patch failed at 0001 Acquisitions - ability to set currency in order screens
Comment 8 Colin Campbell 2011-03-18 13:59:00 UTC
Created attachment 3349 [details] [review]
Original patch rebased
Comment 9 Colin Campbell 2011-03-18 14:00:08 UTC
Created attachment 3350 [details] [review]
Rebased patch
Comment 10 Colin Campbell 2011-03-18 14:01:28 UTC
I've rebased both the original patch and my subsequent fix against current master
Comment 11 Chris Cormack 2011-03-21 04:01:48 UTC
Pushed, please test