Bug 5489 - Send hold email to branch email address if it exists instead of koha email address
Summary: Send hold email to branch email address if it exists instead of koha email ad...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Amit Gupta
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-14 08:15 UTC by Amit Gupta
Modified: 2020-07-10 08:10 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
signed off patch (1.22 KB, patch)
2010-12-17 20:01 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Amit Gupta 2010-12-14 08:15:17 UTC
Send hold email to branch email address if it exists instead of koha email address
Comment 1 Chris Cormack 2010-12-14 08:24:12 UTC
Patch has been sent to the mailing list
Comment 2 Nicole C. Engard 2010-12-17 20:01:01 UTC
Created attachment 2880 [details] [review]
signed off patch
Comment 3 Chris Cormack 2010-12-19 21:24:16 UTC
This will need to be documented prominently in the release notes and manual, since this will change the behaviour and people may suddenly have holds going to an email address they don't know to check for them.

I wonder if we need this to be a systempreference, so that the behaviour doesn't change on people without them needing to make a conscious decision to change it

Pushed to new/enh/bug_5489 ... but not merged until we decide the above question, I certainly lean to not changing current behaviour with no warning (i mean who really reads the release notes :))
Comment 4 Nicole C. Engard 2010-12-19 21:45:12 UTC
If it's a sys pref then it needs to be a sys pref for all notices (hopefully not a pref for each notice - unless we create a whole new tab) because most libraries assume that the branch email is the one used as the from address on notices and as the email that notices go to at the library - otherwise all branches would have to have access to one email account (the admin email). I agree we need to warn people, but I also think it's the way we all assumed things were working in the first place.
Comment 5 Chris Cormack 2010-12-20 08:36:31 UTC
If you can think up a way to make it so that people will know that the emails will being sent to and from a different email address.  (This patch changes both the from and to address of the emails .. was that the intent?). Then I could be persuaded away from a syspref.
Comment 6 Nicole C. Engard 2010-12-20 12:43:06 UTC
I don't really have an answer for you except updating documentation. But if we add a preference for what email to use for notices, it needs to be one preference for ALL notices - or a preference for each type of notice - it can't be a preference just for this notice.
Comment 7 Owen Leonard 2010-12-20 13:26:11 UTC
> If you can think up a way to make it so that people will know that the emails
> will being sent to and from a different email address...

I wonder if we need some kind of system (similar to or part of the updatedatabase prompt) which alerts the user to changes like this? That way we could include messages like "Warning, as part of this update the following changes will be made..."
Comment 8 Chris Cormack 2010-12-21 08:40:48 UTC
Thats a good idea Owen, we could do a <b>WARNING: This will change the behaviour of the hold notices, ....</b> in the updatedatabase, that might suffice for this. Coupled with documentation of course.

I'll try that out, and if it looks good, ill push up a patch for it and merge it into master.
Comment 9 Chris Cormack 2010-12-21 08:43:01 UTC
Except of course we arent doing a database update :)
Comment 10 Chris Cormack 2010-12-21 08:45:45 UTC
Ok, well im merging it and pushing it, and we have until april to think up a good way to make sure people take note :) (for the 3.4.0 release).

Merged to master, please test
Comment 11 MJ Ray (software.coop) 2011-01-10 10:49:04 UTC
This bug is mentioned in:
Bug 5489: Send hold email to	branch email address if it exists instead of koha email address http://lists.koha-community.org/pipermail/koha-patches/2010-December/013412.html
Bug 5489: Send hold email to branch email address if it exists instead of koha email address http://lists.koha-community.org/pipermail/koha-patches/2010-December/013413.html