Send hold email to branch email address if it exists instead of koha email address
Patch has been sent to the mailing list
Created attachment 2880 [details] [review] signed off patch
This will need to be documented prominently in the release notes and manual, since this will change the behaviour and people may suddenly have holds going to an email address they don't know to check for them. I wonder if we need this to be a systempreference, so that the behaviour doesn't change on people without them needing to make a conscious decision to change it Pushed to new/enh/bug_5489 ... but not merged until we decide the above question, I certainly lean to not changing current behaviour with no warning (i mean who really reads the release notes :))
If it's a sys pref then it needs to be a sys pref for all notices (hopefully not a pref for each notice - unless we create a whole new tab) because most libraries assume that the branch email is the one used as the from address on notices and as the email that notices go to at the library - otherwise all branches would have to have access to one email account (the admin email). I agree we need to warn people, but I also think it's the way we all assumed things were working in the first place.
If you can think up a way to make it so that people will know that the emails will being sent to and from a different email address. (This patch changes both the from and to address of the emails .. was that the intent?). Then I could be persuaded away from a syspref.
I don't really have an answer for you except updating documentation. But if we add a preference for what email to use for notices, it needs to be one preference for ALL notices - or a preference for each type of notice - it can't be a preference just for this notice.
> If you can think up a way to make it so that people will know that the emails > will being sent to and from a different email address... I wonder if we need some kind of system (similar to or part of the updatedatabase prompt) which alerts the user to changes like this? That way we could include messages like "Warning, as part of this update the following changes will be made..."
Thats a good idea Owen, we could do a <b>WARNING: This will change the behaviour of the hold notices, ....</b> in the updatedatabase, that might suffice for this. Coupled with documentation of course. I'll try that out, and if it looks good, ill push up a patch for it and merge it into master.
Except of course we arent doing a database update :)
Ok, well im merging it and pushing it, and we have until april to think up a good way to make sure people take note :) (for the 3.4.0 release). Merged to master, please test
This bug is mentioned in: Bug 5489: Send hold email to branch email address if it exists instead of koha email address http://lists.koha-community.org/pipermail/koha-patches/2010-December/013412.html Bug 5489: Send hold email to branch email address if it exists instead of koha email address http://lists.koha-community.org/pipermail/koha-patches/2010-December/013413.html