Bug 5498 - Standardize markup and style of pagination menus
Summary: Standardize markup and style of pagination menus
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) minor
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-15 14:58 UTC by Owen Leonard
Modified: 2013-12-05 20:01 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Unstyled pagination (14.28 KB, image/png)
2010-12-15 14:58 UTC, Owen Leonard 		Details
Styled pagination (4.72 KB, image/png)
2010-12-15 14:59 UTC, Owen Leonard 		Details
Proposed fix (12.76 KB, patch)
2010-12-15 15:49 UTC, Owen Leonard 		Details | Diff | Splinter Review
Revised for current HEAD (12.84 KB, patch)
2011-01-11 13:48 UTC, Owen Leonard 		Details | Diff | Splinter Review
Follow-up fix (1.76 KB, patch)
2011-08-19 18:47 UTC, Owen Leonard 		Details | Diff | Splinter Review
[SIGNED-OFF] Follow-up fix for Bug 5498, Standardize markup and style of pagination menus (1.80 KB, patch)
2011-08-24 18:28 UTC, Nicole C. Engard 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2010-12-15 14:58:47 UTC 
Created attachment 2853 [details]
Unstyled pagination

Several pages in Koha now use the same pagination widget from Output.pm, pagination_bar. At least one instance of this in the Koha templates, patron search results, has been updated to bring the style in line with that of catalog search results pagination. Other instances should get the same style.
Comment 1 Owen Leonard 2010-12-15 14:59:22 UTC 
Created attachment 2854 [details]
Styled pagination
Comment 2 Owen Leonard 2010-12-15 15:49:11 UTC Comment hidden (obsolete)
Comment 3 MJ Ray (software.coop) 2011-01-10 10:48:43 UTC 
This bug is mentioned in:
Fix for bug 5498,	Standardize markup and style of pagination menus http://lists.koha-community.org/pipermail/koha-patches/2010-December/013285.html
Comment 4 Owen Leonard 2011-01-11 13:48:23 UTC Comment hidden (obsolete)
Comment 5 Frederic Durand 2011-04-08 09:53:57 UTC 
A little fix for conflict when applying the patch. Everything else look ok.
Comment 6 Chris Cormack 2011-04-09 07:27:35 UTC 
Pushed, please test
Comment 7 Owen Leonard 2011-08-19 18:47:48 UTC Comment hidden (obsolete)
Comment 8 Nicole C. Engard 2011-08-24 18:28:14 UTC 
Created attachment 5124 [details] [review]
[SIGNED-OFF] Follow-up fix for Bug 5498, Standardize markup and style of pagination menus

Missed a couple of instances of the pagination menu on the
lists page. Previously the pagination links on the page
listing lists (/cgi-bin/koha/virtualshelves/shelves.pl) was
unstyled. After this patch the links should be styled.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Comment 9 Chris Cormack 2011-08-25 00:06:31 UTC 
Follow up pushed, please test
Comment 10 Chris Nighswonger 2011-10-26 18:02:25 UTC 
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.