Bug 5521 - item edit form appears if no items found
Summary: item edit form appears if no items found
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Paul Poulain
URL: /cgi-bin/koha/tools/batchMod.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-19 17:52 UTC by Nicole C. Engard
Modified: 2013-12-05 20:01 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
edit of no items (68.15 KB, image/png)
2010-12-19 17:52 UTC, Nicole C. Engard
Details
Bug 5521 - item edit form appears if no items found (2.11 KB, patch)
2012-10-30 14:55 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 5521 - item edit form appears if no items found (2.17 KB, patch)
2012-10-31 14:48 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 5521 - item edit form appears if no items found (2.21 KB, patch)
2012-11-12 17:28 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2010-12-19 17:52:35 UTC
Created attachment 2884 [details]
edit of no items

When using the batch edit tool if you get no items found you still get the edit item form. If there are no items found there shouldn't be a form to edit them :)
Comment 1 Owen Leonard 2012-10-30 14:55:49 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2012-10-31 14:48:26 UTC Comment hidden (obsolete)
Comment 3 Jared Camins-Esakov 2012-11-01 19:29:57 UTC
String changes. Will hold for post-3.10.0.
Comment 4 Paul Poulain 2012-11-12 17:28:39 UTC
QA comment:
 * template only change
 * passes koha-qa.pl
 * introduces a new string, but it's displayed only in some specific cases (when there is no item found), so I think it's OK for 3.10.0, because the messages before this patch may be of some trouble for users. So, between a troubling (frenchism ?) message and an uncommon english message, I prefer the former.

passed QA
Comment 5 Paul Poulain 2012-11-12 17:28:53 UTC
Created attachment 13404 [details] [review]
Bug 5521 - item edit form appears if no items found

This patch changes the template so that if no items are
found the page doesn't show "The following barcodes were found"
and doesn't show the item edit form.

To test, submit a batch which contains no valid barcodes.
Compare to a batch which contains some or all valid barcodes.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
All tests succeed.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Comment 6 Jared Camins-Esakov 2012-11-12 22:54:45 UTC
(In reply to comment #4)
>  * introduces a new string, but it's displayed only in some specific cases
> (when there is no item found), so I think it's OK for 3.10.0, because the
> messages before this patch may be of some trouble for users. So, between a
> troubling (frenchism ?) message and an uncommon english message, I prefer
> the former.

I disagree. It will break not only the French translation but also translations for the other 43 languages that Koha has been translated into.
Comment 7 Paul Poulain 2012-11-13 09:48:17 UTC
(In reply to comment #6)
> (In reply to comment #4)
> >  * introduces a new string, but it's displayed only in some specific cases
> > (when there is no item found), so I think it's OK for 3.10.0, because the
> > messages before this patch may be of some trouble for users. So, between a
> > troubling (frenchism ?) message and an uncommon english message, I prefer
> > the former.
> 
> I disagree. It will break not only the French translation but also
> translations for the other 43 languages that Koha has been translated into.

I agree/know it will break all translation (the "frenchism?" was refering to the word "troubling", that I'm not sure is English)

But the added string appears only under uncommon circumstances, while a string appearing more frequently is removed. Thus my comment it should be for 3.10
Comment 8 Jared Camins-Esakov 2012-11-23 18:14:14 UTC
This patch has been pushed to master.
Comment 9 Chris Cormack 2012-11-26 02:44:30 UTC
Now the string freeze is passed, this can be pushed to 3.10.x will be in 3.10.1
Comment 10 Chris Cormack 2012-11-26 07:48:13 UTC
Pushed to 3.8.x, will be in 3.8.8
Comment 11 Liz Rea 2012-11-28 22:41:48 UTC
Pushed to 3.6.x will be in 3.6.11.