Created attachment 2884 [details] edit of no items When using the batch edit tool if you get no items found you still get the edit item form. If there are no items found there shouldn't be a form to edit them :)
Created attachment 13117 [details] [review] Bug 5521 - item edit form appears if no items found This patch changes the template so that if no items are found the page doesn't show "The following barcodes were found" and doesn't show the item edit form. To test, submit a batch which contains no valid barcodes. Compare to a batch which contains some or all valid barcodes.
Created attachment 13143 [details] [review] [SIGNED-OFF] Bug 5521 - item edit form appears if no items found This patch changes the template so that if no items are found the page doesn't show "The following barcodes were found" and doesn't show the item edit form. To test, submit a batch which contains no valid barcodes. Compare to a batch which contains some or all valid barcodes. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests succeed.
String changes. Will hold for post-3.10.0.
QA comment: * template only change * passes koha-qa.pl * introduces a new string, but it's displayed only in some specific cases (when there is no item found), so I think it's OK for 3.10.0, because the messages before this patch may be of some trouble for users. So, between a troubling (frenchism ?) message and an uncommon english message, I prefer the former. passed QA
Created attachment 13404 [details] [review] Bug 5521 - item edit form appears if no items found This patch changes the template so that if no items are found the page doesn't show "The following barcodes were found" and doesn't show the item edit form. To test, submit a batch which contains no valid barcodes. Compare to a batch which contains some or all valid barcodes. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests succeed. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(In reply to comment #4) > * introduces a new string, but it's displayed only in some specific cases > (when there is no item found), so I think it's OK for 3.10.0, because the > messages before this patch may be of some trouble for users. So, between a > troubling (frenchism ?) message and an uncommon english message, I prefer > the former. I disagree. It will break not only the French translation but also translations for the other 43 languages that Koha has been translated into.
(In reply to comment #6) > (In reply to comment #4) > > * introduces a new string, but it's displayed only in some specific cases > > (when there is no item found), so I think it's OK for 3.10.0, because the > > messages before this patch may be of some trouble for users. So, between a > > troubling (frenchism ?) message and an uncommon english message, I prefer > > the former. > > I disagree. It will break not only the French translation but also > translations for the other 43 languages that Koha has been translated into. I agree/know it will break all translation (the "frenchism?" was refering to the word "troubling", that I'm not sure is English) But the added string appears only under uncommon circumstances, while a string appearing more frequently is removed. Thus my comment it should be for 3.10
This patch has been pushed to master.
Now the string freeze is passed, this can be pushed to 3.10.x will be in 3.10.1
Pushed to 3.8.x, will be in 3.8.8
Pushed to 3.6.x will be in 3.6.11.