Bug 5522 - The 'open in new window' setting should apply to google preview and ebook links
Summary: The 'open in new window' setting should apply to google preview and ebook links
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Robin Sheat
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-19 23:44 UTC by Robin Sheat
Modified: 2012-10-25 23:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (6.00 KB, patch)
2010-12-20 02:03 UTC, Robin Sheat
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Sheat 2010-12-19 23:44:42 UTC
It doesn't seem to be working at the moment.
Comment 1 Robin Sheat 2010-12-19 23:46:23 UTC
I take that back, it does work for ebooks. Not for google preview, though. Will have to see if this is possible.
Comment 2 Robin Sheat 2010-12-20 02:03:14 UTC
Created attachment 2885 [details] [review]
Proposed patch
Comment 3 Nicole C. Engard 2010-12-20 12:34:56 UTC
I have fixed the whitespace errors and signed off - I hope I did that edits right :)
Comment 4 Chris Cormack 2010-12-21 01:35:06 UTC
Pushed please test
Comment 5 MJ Ray (software.coop) 2011-01-11 12:58:03 UTC
This bug is mentioned in:
Bug 5522 - allow google preview	to open in a new window http://lists.koha-community.org/pipermail/koha-patches/2010-December/013432.html
Bug 5522 - allow google preview to open in a	new window http://lists.koha-community.org/pipermail/koha-patches/2010-December/013427.html