Bug 5531 - Missing sysprefs in language specific files
Summary: Missing sysprefs in language specific files
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
: 5474 (view as bug list)
Depends on:
Blocks: 5474
  Show dependency tree / graph
 
Reported: 2010-12-21 09:37 UTC by Chris Cormack
Modified: 2012-10-25 23:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-12-21 09:37:26 UTC 
In the future we plan to have all the systempreferences inserted into the db on install from the English file. Because they are now translatable with the .pref files so we don't need language specific ones.

But at the moment that isn't the case, and there are some missing sysprefs in the language specific which would cause a mess if someone did a fresh install in a language other than english at the moment.

This bug is to track the fixes for that, a new bug to change the installer to use the english sysprefs.sql file and use the prefs.po file in the appropriate language to translate them
Comment 1 dev_patches 2010-12-21 23:30:47 UTC 
branch pushed wip/sysprefs_translated 
on wip/koha-biblibre.git
It removes some sysprefs used in the code though.
So maybe would need some more reconciliation with .pref and sysprefs.sql work.
Comment 2 Chris Cormack 2010-12-22 02:12:56 UTC 
Pushed a bunch of patches, have gotten the tests all passing, all the languages match english. Next step is to check there are none missing in the english one as Henri-Damien suggests
Comment 3 Paul Poulain 2011-11-05 09:04:01 UTC 
*** Bug 5474 has been marked as a duplicate of this bug. ***