Bug 5540 - editing slip news changes to librarian interface
Summary: editing slip news changes to librarian interface
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL: cgi-bin/koha/tools/koha-news.pl?op=ad...
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-23 18:06 UTC by Nicole C. Engard
Modified: 2012-10-25 22:52 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (2.27 KB, patch)
2010-12-28 15:54 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2010-12-23 18:06:03 UTC
When you're editing a news item that has been designated for the 'slip' it changes the type to 'librarian interface' - if you don't notice that it does that you end up putting news in the wrong place.  All other types of news edit properly, it's just the slip that's funny.
Comment 1 Owen Leonard 2010-12-28 15:54:06 UTC
Created attachment 2913 [details] [review]
Proposed fix

    The script checks for a language-specific OPAC message and, if none
    is found, preselects none of the "display location" options. This
    results in the first item in the <select> behing highlighted by
    default, "Librarian interface." If we want to select "slip," we
    must add an explicit check for it.
Comment 2 Chris Cormack 2010-12-29 07:41:39 UTC
Pushed, please test