Bug 5557 - Logs cannot be viewed by user with granular permission view_system_logs
Summary: Logs cannot be viewed by user with granular permission view_system_logs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Transaction logs (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) trivial (vote)
Assignee: Janusz Kaczmarek
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-30 11:04 UTC by Janusz Kaczmarek
Modified: 2012-10-25 23:03 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Suggested changes reformatted as a patch (1.81 KB, patch)
2010-12-30 17:22 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2010-12-30 11:04:17 UTC
Proposed correction: in biblio-view-menu.inc change CAN_user_parameters to CAN_user_tools_view_system_logs.

Regards,

Janusz

--- ../koha-3.2.2/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc 2010-12-22 01:58:29.000000000 +0200
+++ /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/includes/biblio-view-menu.inc 2010-12-28 11:22:51.000000000 +0200
@@ -29,7 +29,7 @@
 <ul>
 <!-- TMPL_IF NAME="issuehistoryview" --><li class="active"><!-- TMPL_ELSE --><li><!-- /TMPL_IF -->
 <a href="/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=<!-- TMPL_IF NAME="object" --><!-- TMPL_VAR NAME="object" --><!-- TMPL_ELSE --><!-- TMPL_IF NAME="object" --><!-- TMPL_VAR NAME="object" --><!-- TMPL_ELSE --><!-- TMPL_VAR NAME="biblionumber" --><!-- /TMPL_IF --><!-- /TMPL_IF -->" >Checkout history</a></li>
-<!-- TMPL_IF NAME="CAN_user_parameters"--><!-- TMPL_IF NAME="logview" --><li class="active"><!-- TMPL_ELSE --><li><!-- /TMPL_IF --><a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&amp;modules=CATALOGUING&amp;action=MODIFY&amp;object=<!-- TMPL_VAR NAME="biblionumber"-->">Modification log</a> </li><!-- /TMPL_IF -->
+<!-- TMPL_IF NAME="CAN_user_tools_view_system_logs"--><!-- TMPL_IF NAME="logview" --><li class="active"><!-- TMPL_ELSE --><li><!-- /TMPL_IF --><a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&amp;modules=CATALOGUING&amp;action=MODIFY&amp;object=<!-- TMPL_VAR NAME="biblionumber"-->">Modification log</a> </li><!-- /TMPL_IF -->
 </ul>
 </div>
Comment 1 Owen Leonard 2010-12-30 17:22:18 UTC
Created attachment 2928 [details] [review]
Suggested changes reformatted as a patch

Changes tested fine, so I went ahead and signed off at the same time.
Comment 2 Chris Cormack 2011-01-03 09:04:07 UTC
Pushed please test
Comment 3 MJ Ray (software.coop) 2011-01-10 10:49:12 UTC
This bug is mentioned in:
Reimplement fix for bug 5557 -	Link to logs for user with view_system_logs permission http://lists.koha-community.org/pipermail/koha-patches/2010-December/013481.html