Created attachment 2937 [details] first two have item types listed On the 'editions' tab in the opac the item type is only showing sometimes.
Created attachment 2938 [details] item type is available for ones w/out on editions tab
On further look it seems that if the item doesn't have a call number it doesn't show the item type ...
I think the call number connection is a red herring. It looks to me like it's trying to pull the biblio-level item type description. Tested with a record which had no biblio-level item type: No item type display. After adding a biblio-level item type: item type appeared.
Created attachment 2942 [details] [review] Proposed fix The item type which shows on other editions is the biblio-level itemtype. ISBN.pm had some item-handling code, but I'm removing it because it is unused. The editions tab should now display item type only if item-level itemtypes are not enabled.
Signed off on patch, but I forgot to check the staff client and the staff client is also showing those item types incorrectly, so this is an issue in the staff client as well as the OPAC (should I do another bug for that?).
I'll work on a follow-up.
Created attachment 2962 [details] [review] Follow-up fix Fix for the staff client.
Both patches pushed, please test