Bug 5570 - item types not showing on other editions
Summary: item types not showing on other editions
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-03 14:29 UTC by Nicole C. Engard
Modified: 2012-10-25 23:03 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
first two have item types listed (96.46 KB, image/png)
2011-01-03 14:29 UTC, Nicole C. Engard
Details
item type is available for ones w/out on editions tab (88.34 KB, image/png)
2011-01-03 14:29 UTC, Nicole C. Engard
Details
Proposed fix (4.29 KB, patch)
2011-01-04 15:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Follow-up fix (3.06 KB, patch)
2011-01-06 21:20 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-01-03 14:29:14 UTC
Created attachment 2937 [details]
first two have item types listed

On the 'editions' tab in the opac the item type is only showing sometimes.
Comment 1 Nicole C. Engard 2011-01-03 14:29:49 UTC
Created attachment 2938 [details]
item type is available for ones w/out on editions tab
Comment 2 Nicole C. Engard 2011-01-03 14:32:55 UTC
On further look it seems that if the item doesn't have a call number it doesn't show the item type ...
Comment 3 Owen Leonard 2011-01-04 15:42:43 UTC
I think the call number connection is a red herring. It looks to me like it's trying to pull the biblio-level item type description. Tested with a record which had no biblio-level item type: No item type display. After adding a biblio-level item type: item type appeared.
Comment 4 Owen Leonard 2011-01-04 15:44:22 UTC
Created attachment 2942 [details] [review]
Proposed fix

The item type which shows on other editions is the biblio-level itemtype. ISBN.pm had some item-handling code, but I'm removing it because it is unused. The editions tab should now display item type only if item-level itemtypes are not enabled.
Comment 5 Nicole C. Engard 2011-01-04 17:50:09 UTC
Signed off on patch, but I forgot to check the staff client and the staff client is also showing those item types incorrectly, so this is an issue in the staff client as well as the OPAC (should I do another bug for that?).
Comment 6 Owen Leonard 2011-01-04 17:57:31 UTC
I'll work on a follow-up.
Comment 7 Owen Leonard 2011-01-06 21:20:39 UTC
Created attachment 2962 [details] [review]
Follow-up fix

Fix for the staff client.
Comment 8 Chris Cormack 2011-01-07 01:27:33 UTC
Both patches pushed, please test