When running advance_notices.pl, numerous lines of the following are generated: Use of uninitialized value in hash element at /home/koha/kohaclone/C4/Members/Messaging.pm line 101. Investigation shows this is due to the SQL in GetMessagingPreferences returning null values for message_transport_type for advanced messaging types NOT utilized by patrons. The solution is to change the LEFT JOIN on line 77 to JOIN; this eliminates the NULL entries. Apparently, the patch for bug 4254 didn't factor in that NULL values would be returned now that the duplicate columns were eliminated.
Created attachment 2972 [details] [review] patch
Pushed, please test
This bug is mentioned in: Bug 5603: advance_notice.pl uninitialized element in hash http://lists.koha-community.org/pipermail/koha-patches/2011-January/013574.html
Tested, works.