Bug 5604 - additional icons for the Seshat set
Summary: additional icons for the Seshat set
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) normal
Assignee: Nicole C. Engard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-11 06:10 UTC by Nicole C. Engard
Modified: 2012-10-25 23:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
patch (57.83 KB, patch)
2011-01-11 06:44 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Patch doing git mv to correct filename (9.21 KB, patch)
2011-10-07 12:39 UTC, Chris Nighswonger
Details | Diff | Splinter Review
Signed-off patch (9.32 KB, patch)
2011-11-10 21:23 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 5604 : Follow up for missing image (843 bytes, patch)
2011-12-06 21:18 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-01-11 06:10:45 UTC
The Seshat set by Naropa is missing some icons.  These will be submitted in a few patches.
Comment 1 Nicole C. Engard 2011-01-11 06:44:04 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2011-01-11 10:06:09 UTC
Pushed, please test
Comment 3 Nicole C. Engard 2011-01-11 22:05:23 UTC
works and there will be at least one more patch coming with additional icons for this set so I'm removing the patch sent/pushed statuses.
Comment 4 MJ Ray (software.coop) 2011-02-02 08:52:22 UTC
This bug is mentioned in:
bug 5604 additional icons in	the Seshat icon set http://lists.koha-community.org/pipermail/koha-patches/2011-January/013566.html
Comment 5 Katrin Fischer 2011-08-14 12:00:21 UTC
Hi Nicole, 
can this be closed now?
Comment 6 Nicole C. Engard 2011-08-16 23:19:52 UTC
I'll reopen if we have more - they are working on more, but it's not a big deal.
Comment 7 Chris Nighswonger 2011-10-07 12:37:36 UTC
Typo in filename adds a space which causes problems in some situations. Attaching a patch to fix.
Comment 8 Chris Nighswonger 2011-10-07 12:39:00 UTC Comment hidden (obsolete)
Comment 9 Owen Leonard 2011-11-10 21:23:55 UTC Comment hidden (obsolete)
Comment 10 Paul Poulain 2011-12-06 18:47:26 UTC
QA comment: none, small patch

Patch pushed, please test
Comment 11 Chris Nighswonger 2011-12-06 19:18:22 UTC
This patch does not apply cleanly to the 3.6.x branch. Please rebase over 3.6.x and attach a corrected patch to this bug report.
Comment 12 Chris Nighswonger 2011-12-06 19:19:11 UTC
I guess that'll be me. ;-)
Comment 13 Chris Cormack 2011-12-06 21:18:52 UTC
Created attachment 6617 [details] [review]
Bug 5604 : Follow up for missing image

When doing icons, there is a test for them please run

perl xt/author/icondirectories.t
Comment 14 Paul Poulain 2011-12-07 17:07:32 UTC
Follow-up tested, fixes the jenkins test,

patch pushed, please test