If you tranlate the message names in the installer sql files your messages will stop working, because the code relies on those have a specific value. - advance_notices.pl - C4/Members/Messaging.pm - C4/Form/MessagingPreferences.pm ... In C4/Members/Messaging.pm I found following lines: 47 my $preferences = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $borrower->{'borrowernumber'}, 48 message_name => 'DUE' } ); 50 my $preferences = C4::Members::Messaging::GetMessagingPreferences( { categorycode => 'LIBRARY', 51 message_name => 'DUE' } ); We don't have DUE as a message name in the en file. Bug? Patch will undo my translation and other people's translations of those values. This means message names in borrower category and borrower account are not translatable at the moment. I think we need to change the templates to make them translatable?
Created attachment 3015 [details] [review] proposed patch
Ok, the 'DUE' appears only in the POD - so this is not a real bug. So we can ignore that. But translating those messages is still a really bad idea.
This bug is mentioned in: Bug 5646: Translated sql files break messaging http://lists.koha-community.org/pipermail/koha-patches/2011-January/013690.html Bug 5646: Translated sql files break messaging http://lists.koha-community.org/pipermail/koha-patches/2011-January/013691.html
Katrin/Julian = Sophie (BibLibre) has improved Koha to have extended messaging be translatable. Julian, pls search on git.biblibre.com, it has be done last week
Paul, does the sign off still hold then?
OK, sorry, more explanations needed... The description of advanced notices in SQL is meaningfull for Koha. Thus, the way Katrin solved the problem in a previous patch was wrong. This patch is a kind of "revert" or another one, solving the functionnal problem (ie: adv notices now work again for german), but not the translation problem. Sophie worked recently on a patch that solves the translation problem correctly. So: 1- yes, pls apply this patch 2- when we will submit our patch, it will be relevant I hope it's more understandable now !
I submitted the patch from BibLibre. (Bug 5889)
Patch pushed, please test
This bug is mentioned in: Bug 5646: Translated sql files break messaging http://lists.koha-community.org/pipermail/koha-patches/2011-March/014056.html