Bug 5649 - Change wording on review.tmpl from white/blacklists to approved/rejected
Summary: Change wording on review.tmpl from white/blacklists to approved/rejected
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) trivial (vote)
Assignee: David Schuster
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-22 03:52 UTC by David Schuster
Modified: 2012-10-25 23:03 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch to change the wording on review.tmpl (1.40 KB, patch)
2011-01-27 04:35 UTC, David Schuster
Details | Diff | Splinter Review
Missed "Test blacklist" in the first patch sorry. (1.21 KB, patch)
2011-02-09 22:28 UTC, David Schuster
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Schuster 2011-01-22 03:52:37 UTC
In the US this is a ratial slur.
Comment 1 David Schuster 2011-01-27 04:35:31 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2011-01-28 13:48:46 UTC
Please note that a bug cannot be marked "fixed" until the patch has been submitted, the patch is signed off on, the patch has been pushed to master, and the patch is tested.

This patch needs a correction: it only corrects one of two instances of the term "blacklist."
Comment 3 Nicole C. Engard 2011-01-28 14:12:30 UTC
Owen,

I did a search on the page and didn't find another one - where was it? I wouldn't have signed off if I had found it.

Sorry about that.

Nicole
Comment 4 Owen Leonard 2011-01-28 14:19:29 UTC
> I did a search on the page and didn't find another one

The patch attached to this bug report doesn't correct this: 

<h4>Test Blacklist</h4>

I didn't realize this got a signoff. I just saw it go from patch attached to "fixed," so I thought a step had been missed.
Comment 5 Nicole C. Engard 2011-01-28 14:23:38 UTC
You were right, a step was skipped - it hadn't been pushed yet, but it had been signed off (I just didn't update the bug report - my bad).  I'll wait for David to update his patch and gladly sign off again.
Comment 6 Chris Cormack 2011-01-29 06:32:50 UTC
Pushed please test
Comment 7 David Schuster 2011-02-09 22:28:54 UTC
Created attachment 3115 [details] [review]
Missed "Test blacklist" in the first patch sorry.

Sorry for the additional work.  I couldn't figure out how to "amend" my original patch.
Comment 8 Nicole C. Engard 2011-02-09 23:11:33 UTC
Signed off on follow up
Comment 9 Chris Cormack 2011-02-13 21:34:33 UTC
Pushed, please test and mark resolved