Bug 5657 - biblio records update fails when updating multiple authorities linked with the same biblio
Summary: biblio records update fails when updating multiple authorities linked with th...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: 3.6
Hardware: All All
: P3 normal (vote)
Assignee: Janusz Kaczmarek
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-25 18:39 UTC by Janusz Kaczmarek
Modified: 2013-12-05 19:59 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (1.67 KB, application/octet-stream)
2011-01-25 18:39 UTC, Janusz Kaczmarek
Details
A refreshed version of the patch (1.72 KB, patch)
2012-02-01 18:06 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 5657: Changes made to sub merge to eliminate errors occuring when updating bibio records in batch (after updating multiple authority records) (1.78 KB, patch)
2012-03-10 16:42 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2011-01-25 18:39:31 UTC Comment hidden (obsolete)
Comment 1 MJ Ray (software.coop) 2011-02-05 19:01:21 UTC
This bug is mentioned in:
Bug 5657 Changes made to sub merge to	eliminate errors occuring when updating bibio records in	batch (after updating multiple authority records) http://lists.koha-community.org/pipermail/koha-patches/2011-January/013701.html
Comment 2 Stéphane Delaune 2011-04-06 13:13:27 UTC
This patch conflicts with patch bug 5943. It just changes the sub merge C4::AuthoritiesMarc::merge which is only used by function C4::AuthoritiesMarc::ModAuthority if (C4::Context->preference('MergeAuthoritiesOnUpdate') ). This syspref does not exist by default. So it makes me doubt the relevance of this patch
Comment 3 Janusz Kaczmarek 2011-04-06 13:28:13 UTC
I am wondering--and how then about the merge_authority.pl script (it makes use of C4::AuthoritiesMarc::merge), which in turn should be executed (as cron job for example, if I understand well) if MergeAuthoritiesOnUpdate is off (which is the default)...?
Comment 4 Marcel de Rooy 2011-11-30 14:38:50 UTC
Applying: Changes made to sub merge to eliminate errors occuring when updating bibio records in batch (after updating multiple authority records)
error: patch failed: C4/AuthoritiesMarc.pm:1299
error: C4/AuthoritiesMarc.pm: patch does not apply
fatal: sha1 information is lacking or useless (C4/AuthoritiesMarc.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Comment 5 Janusz Kaczmarek 2012-02-01 18:06:29 UTC Comment hidden (obsolete)
Comment 6 Jared Camins-Esakov 2012-03-10 16:42:56 UTC
Created attachment 8145 [details] [review]
Bug 5657: Changes made to sub merge to eliminate errors occuring when updating bibio records in batch (after updating multiple authority records)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 7 Ian Walls 2012-03-14 14:47:16 UTC
Looks like this patch changes a direct passage of the Zebra MARC record result to a re-fetch, based on the biblionumber.  This should help eliminate conditions where the details of a record change mid-stream, at the cost of some processing time.

Change looks good, marking as Passed QA.
Comment 8 Paul Poulain 2012-03-21 10:14:58 UTC
This patch result in a loss of performance, but it's much better than losing things ;-)
(I haven't numbers, but instead of just retrieving from zebra, there are additional SQL queries to retrieve the data, so it can only be slower)
Comment 9 Jared Camins-Esakov 2012-05-09 16:56:08 UTC
This bug will be included in the Koha 3.6.5 release.