Bug 5660 - Webinstaller should check if KohaOpacLanguage exists in staff
Summary: Webinstaller should check if KohaOpacLanguage exists in staff
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Marcel de Rooy
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 7026
  Show dependency treegraph
 
Reported: 2011-01-26 15:03 UTC by Marcel de Rooy
Modified: 2012-10-25 23:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch (1.79 KB, patch)
2011-01-26 15:25 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Revised patch (1.85 KB, patch)
2011-04-07 12:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Rebased patch (1.85 KB, patch)
2011-04-11 08:29 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Rebased patch (2.01 KB, patch)
2011-04-11 08:37 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Rebased patch (2.08 KB, patch)
2011-04-27 10:00 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Signed off patch (2.10 KB, patch)
2011-05-17 00:46 UTC, Chris Cormack
Details | Diff | Splinter Review
proposed patch (passed QA) (2.14 KB, patch)
2011-08-04 12:55 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2011-01-26 15:03:50 UTC
While upgrading, I stumbled into this error: 
[error] [client ...] built-in find_file: can't find file /usr/share/koha/testclone/koha-tmpl/intranet-tmpl/prog/nl-NL/modules/installer/step3.tmpl with path = [ '/usr/share/koha/testclone/koha-tmpl/intranet-tmpl/prog/nl-NL/includes' ], referer: http://.../cgi-bin/koha/installer/install.pl?step=3

What is the case? I installed language nl-NL only on the opac side. But the installer simply assumes it to be on the intranet side too.

Will send a small patch for this bug.
Comment 1 Marcel de Rooy 2011-01-26 15:25:25 UTC Comment hidden (obsolete)
Comment 2 MJ Ray (software.coop) 2011-02-06 11:14:03 UTC
This bug is mentioned in:
Bug 5660: Webinstaller should check if KohaOpacLanguage exists on staff side http://lists.koha-community.org/pipermail/koha-patches/2011-January/013705.html
Comment 3 Marcel de Rooy 2011-04-07 12:28:59 UTC Comment hidden (obsolete)
Comment 4 Marcel de Rooy 2011-04-11 08:29:00 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2011-04-11 08:37:21 UTC Comment hidden (obsolete)
Comment 6 Chris Cormack 2011-04-11 21:55:29 UTC
I would like to get this into the 3.4.0 release, can someone sign off please
Comment 7 Marcel de Rooy 2011-04-27 10:00:54 UTC Comment hidden (obsolete)
Comment 8 Chris Cormack 2011-05-17 00:46:37 UTC Comment hidden (obsolete)
Comment 9 Paul Poulain 2011-08-04 12:55:15 UTC
Created attachment 4840 [details] [review]
proposed patch (passed QA)

QA comment

Nothing specific to say: small (& usefull) patch, no DB change, no internal change
Comment 10 Chris Cormack 2011-08-04 23:10:49 UTC
Pushed
Comment 11 Marcel de Rooy 2011-10-03 07:25:34 UTC
Closing it myself now; waited two months..