Bug 5714 - Unescaped ampersands in OPAC facets
Summary: Unescaped ampersands in OPAC facets
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-08 16:00 UTC by Owen Leonard
Modified: 2012-10-25 23:10 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (7.09 KB, patch)
2011-02-08 16:03 UTC, Owen Leonard
Details | Diff | Splinter Review
Revised fix (4.53 KB, patch)
2011-05-27 12:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Signed-off patch (4.55 KB, patch)
2011-05-28 23:02 UTC, Magnus Enger
Details | Diff | Splinter Review
Follow-up fix (1.41 KB, patch)
2011-06-10 19:32 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2011-02-08 16:00:17 UTC
Unescaped ampersands are being sent to the template in the query_cgi variable.
Comment 1 Owen Leonard 2011-02-08 16:03:14 UTC Comment hidden (obsolete)
Comment 2 MJ Ray (software.coop) 2011-03-06 12:10:04 UTC
This bug is mentioned in:
Fix for Bug 5714,	Unescaped ampersands in OPAC facets http://lists.koha-community.org/pipermail/koha-patches/2011-February/013785.html
Comment 3 Katrin Fischer 2011-03-14 06:34:11 UTC
I am not sure how to test this. I experimented with a subject heading "A & B" but saw no problems in display or search. Can you explain how to reproduce the problem?
Comment 4 Jared Camins-Esakov 2011-03-17 13:55:04 UTC
I think think this is probably caused by using rebuild_zebra.pl -b -x, but I was unable to apply this patch to test. Merge conflicts in koha-tmpl/opac-tmpl/prog/en/includes/page-numbers.inc and koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc
Comment 5 Owen Leonard 2011-05-27 12:59:33 UTC Comment hidden (obsolete)
Comment 6 Magnus Enger 2011-05-28 23:02:27 UTC Comment hidden (obsolete)
Comment 7 Ian Walls 2011-06-03 20:44:45 UTC
Template change, and good test report by Magnus.  marking as Passed QA
Comment 8 Chris Cormack 2011-06-04 07:46:30 UTC
Pushed to master, please test
Comment 9 Ian Walls 2011-06-10 17:18:01 UTC
This patch adds the query_cgi directly to the template, without styling, right above the first facet.  I believe this was in there for debugging purposes, and needs to be removed or styled in such as way that it can be suppressed (we've got some libraries reporting that it's unattractive).
Comment 10 Owen Leonard 2011-06-10 19:32:02 UTC
Created attachment 4443 [details] [review]
Follow-up fix
Comment 11 Chris Cormack 2011-06-15 00:41:21 UTC
Whoops I fixed this without noticing Owen already had