Bug 5735 - Expanding/collapsing cloned fields in editor takes original field
Summary: Expanding/collapsing cloned fields in editor takes original field
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Marcel de Rooy
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-10 10:38 UTC by Marcel de Rooy
Modified: 2012-10-25 23:03 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch (1.99 KB, patch)
2011-02-10 10:44 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2011-02-10 10:38:34 UTC
Add a new field by cloning with + button.
Expand/collapse the new field by clicking the field label (marc field name).
The original (first) field expands/collapses.

Patch corrects this bug in javascript.
Comment 1 Marcel de Rooy 2011-02-10 10:44:07 UTC
Created attachment 3120 [details] [review]
Patch
Comment 2 Marcel de Rooy 2011-02-10 11:26:11 UTC
Additional observation: the removed code did no longer work, because the ? link was added recently to the marc loc page. This url in the cloned fields now does the expanding and collapsing of the right field. This behavior comes from just adjusting the onclick of the first link in the array and not testing it (in the old code).

The new code tests the class of the link, restoring the correct behavior of both links.
Comment 3 Chris Cormack 2011-02-13 20:56:48 UTC
Pushed, please test and mark resolved