On OPAC result page facets are truncated to 20 characters. On some OPAC layout, it's not enough. A new syspref FacetOpacMaxLength defines the length to cut facets if necessary.
Created attachment 3143 [details] [review] Proposed patch
(In reply to comment #1) > Created attachment 3143 [details] [review] > Proposed patch I think "FacetOpacMaxLength" is too ambiguous. It may signify the number of biblio used in the computation of facets. Also, Search.pm is for both OPAC and Intranet. So both will be impacted by the system pref, no? I suggest "FacetLabelMaxLength". Regards,
> I think "FacetOpacMaxLength" is too ambiguous. It may signify the > number of biblio used in the computation of facets. An English speaking person may have to say his word on that. > Also, Search.pm is for both OPAC and Intranet. So both will be > impacted by the system pref, no? Yes, you get a point. > I suggest "FacetLabelMaxLength". Or FacetTruncationLength? Thanks.
(In reply to comment #3) > > Or FacetTruncationLength? > Ok, but with "label" : FacetLabelTruncationLength Regards,
Created attachment 3161 [details] [review] Version with Frydolin syspref name
> Version with Frydolin syspref name Fridolyn...
This bug is mentioned in: Bug 5755: Syspref to control facets truncation http://lists.koha-community.org/pipermail/koha-patches/2011-February/013849.html Bug 5755: Syspref to control facets truncation http://lists.koha-community.org/pipermail/koha-patches/2011-February/013851.html Bug 5755: Syspref to control facets truncation http://lists.koha-community.org/pipermail/koha-patches/2011-February/013853.html Bug 5755: Syspref to control facets truncation http://lists.koha-community.org/pipermail/koha-patches/2011-February/013875.html
Patch does not apply. I think it comes from '\ No newline at end of file' lines. These lines are present in both proposed patches.
(In reply to comment #8) > Patch does not apply. I think it comes from > '\ No newline at end of file' > lines. > These lines are present in both proposed patches. Thanks Julian for trying. This is due to a merge conflict. This patch affects syspref definition files which have changed since the patch submission. I will try to find time to rebase it to master and resubmit.
Created attachment 3283 [details] [review] New version rebased on HEAD
Tested, it works.
Are we sure we dont want to add an updatedatabase for this? That means no one who ever upgrades can get this new feature. Only people who newly install can ... Please submit a follow up patch doing the updatedatabase to insert the syspref, defaulting it to 20, so that people upgrading can now (or in the future) turn this on.
> Are we sure we dont want to add an updatedatabase for this? That > means no one who ever upgrades can get this new feature. Only people > who newly install can ... It isn't actually correct. People will just have to go in Administration > System preferences > Searching tab > Result Display section. Their, they will find FacetLabelTruncationLength syspref since the patch add it to search.tmpl.
I am not sure this will not add confusion. If I understand this correctly there will be no entry in the sys pref table until the sys pref is changed? Perhaps we should not do this different from the other sys prefs without a good reason.
> I am not sure this will not add confusion. If I understand this > correctly there will be no entry in the sys pref table until the sys > pref is changed? You understand correctly! Chris, please, just confirm you want an DB update for this syspref. I will send it. Thanks.
Yes please, lets do it the same as the others a least until 3.4 is released :)
Signed off on the two patches.
Pushed please test