Hie, "ReservesControlBranch" system preference is present in interface and udpatedatabase.pl but not in SQL installation scripts "sysprefs.sql". It's quite buggy in a fresh installation. Regards,
This bug is still valid for current master.
Created attachment 9193 [details] [review] Bug 5795 - Missing ReservesControlBranch system pref in database installer sysprefs.sql file was missing ReservesControlBranch. To test: 1) Create a new installation and check sysprefs.sql loads correctly. 2) Check ReservesControlBranch shows up correctly in the sys pref editor. 3) Check sys pref can be edited and new value saves correctly.
Created attachment 9320 [details] [review] Bug 5795 [SIGNED-OFF] - Missing ReservesControlBranch system pref in database installer sysprefs.sql file was missing ReservesControlBranch. To test: 1) Create a new installation and check sysprefs.sql loads correctly. 2) Check ReservesControlBranch shows up correctly in the sys pref editor. 3) Check sys pref can be edited and new value saves correctly. Signed-off-by: Marc Veron <veron@veron.ch> - Line is added at the end of installer/data/mysql/sysprefs.sql - Tested Line diretly in MySQL with a systempreferences table where variable 'ReservesControlBranch' was missing. Data inserted correctly. - Syspref shows up in Staff client
Created attachment 9397 [details] [review] Update the database as follow-up to Bug 5795 Update the database as follow-up to Bug 5795 If value is not exist it insert other wise update the existing value. To Test: 1) Go to mysql use koha database 2) select * from systempreferences where variable = 'ReservesControlBranch'; 3) It Show old result if value is present other wise it shows: +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | variable | value | options | explanation | type | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | ReservesControlBranch | ItemHomeLibrary | ItemHomeLibrary|PatronLibrary | Branch checked for members reservations rights. | Choice | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+
Created attachment 9451 [details] [review] Update the database as follow-up to Bug 5795 If sys pref ReservesControlBranch has null then update the table to insert a ItemHomeLibrary as value To Test: 1) Go to mysql use koha database 2) select * from systempreferences where variable = 'ReservesControlBranch'; Check if value set to ItemHomeLibrary. +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | variable | value | options | explanation | type | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | ReservesControlBranch | ItemHomeLibrary | ItemHomeLibrary|PatronLibrary | Branch checked for members reservations rights. | Choice | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+
Can we define Bug 7970 has duplicate of this one ? No need to have the same patche in two bugs.
Fridolyn SOMERS You can mark bug 7970 as a duplicate.
*** Bug 7970 has been marked as a duplicate of this bug. ***
Created attachment 9541 [details] [review] Bug 5795 [SIGNED-OFF] - Missing ReservesControlBranch system pref in database installer sysprefs.sql file was missing ReservesControlBranch. To test: 1) Create a new installation and check sysprefs.sql loads correctly. 2) Check ReservesControlBranch shows up correctly in the sys pref editor. 3) Check sys pref can be edited and new value saves correctly. Signed-off-by: Marc Veron <veron@veron.ch> - Line is added at the end of installer/data/mysql/sysprefs.sql - Tested Line diretly in MySQL with a systempreferences table where variable 'ReservesControlBranch' was missing. Data inserted correctly. - Syspref shows up in Staff client Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> - Fixed merge conflict
Created attachment 9542 [details] [review] Bug 5795 Update the database as follow-up If sys pref ReservesControlBranch has null then update the table to insert a ItemHomeLibrary as value To Test: 1) Go to mysql use koha database 2) select * from systempreferences where variable = 'ReservesControlBranch'; Check if value set to ItemHomeLibrary. +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | variable | value | options | explanation | type | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | ReservesControlBranch | ItemHomeLibrary | ItemHomeLibrary|PatronLibrary | Branch checked for members reservations rights. | Choice | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
QA Comments, A little comment: First patch (syspref.sql) insert the syspref with the "PatronLibrary" default value whereas updatedatabase insert with "ItemHomeLibrary". Marking as Failed QA.
PatronLibrary as default value.
Created attachment 9695 [details] [review] Bug 5795 Update the database as follow-up If sys pref ReservesControlBranch has null then update the table to insert a PatronLibrary as value Bug 5795 Update the database as follow-up If sys pref ReservesControlBranch has null then update the table to insert a PatronLibrary as value To Test: 1) Go to mysql use koha database 2) select * from systempreferences where variable = 'ReservesControlBranch'; Check if value set to ItemHomeLibrary. +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | variable | value | options | explanation | type | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | ReservesControlBranch | PatronLibrary | ItemHomeLibrary|PatronLibrary | Branch checked for members reservations rights. | Choice | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ PatronLibrary as default value.
Previous patch is already signed off by Chris
QA comment: Last patch modify the default value for the syspref. Marking as Passed QA
Pushed to 3.8.x, will be in 3.8.2