The patch for Bug 5782 added a duplicate check when ordering from an external source. The new template file could use some cleaning up and maybe some text clean up or streamlined display. I don't have any specific suggestions at this time, I just wanted to get the report out there.
Created attachment 3207 [details] Screenshot of suggested revision
Owen, you never cease to amaze me! I love it!
Created attachment 3210 [details] [review] Proposed fix
Pushed please test
Good work! Two very small points that could be improved: 1) Typo: Crete new record -> Create new record 2) The third box doesn't align with the other two in my browser, since the line Return to the basket.. is shorter. I would prefer to see all three the same size with the command buttons at the same height.
Oopsie! missed that typo. As for the boxes, what browser/operating system combo are you on? My boxes lined up in FF on Mac.
Created attachment 3225 [details] [review] Follow-up fix
With regard to the differently-sized boxes: These are independently-rendered <div>s, so without making the letter count of each box the same there will be differences. The alternative would be using jQuery to make them the same size, which I think is overkill for a minor size difference.
This bug is mentioned in: Fix for Bug 5804 - duplicate warning when ordering needs design work http://lists.koha-community.org/pipermail/koha-patches/2011-February/013926.html Fix for Bug 5804 - duplicate warning when ordering needs design work http://lists.koha-community.org/pipermail/koha-patches/2011-February/013924.html Follow-up fix for Bug 5804, acqui duplicate warning http://lists.koha-community.org/pipermail/koha-patches/2011-February/013946.html Follow-up fix for Bug 5804, acqui duplicate warning http://lists.koha-community.org/pipermail/koha-patches/2011-February/013947.html
Follow up patch needs signoff
Does it? I tried to apply and test and it says it's already applied: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Follow-up fix for Bug 5804, acqui duplicate warning Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... No changes -- Patch already applied. nengard@debian:~/kohaclone$
Has been pushed already. Tested and closed.