Bug 5819 - No toolbar in record view when quotes present in title
Summary: No toolbar in record view when quotes present in title
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: unspecified
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Janusz Kaczmarek
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-01 22:20 UTC by Janusz Kaczmarek
Modified: 2012-10-25 23:03 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
A screenshot illustrating the problem (55.85 KB, image/png)
2011-03-01 22:20 UTC, Janusz Kaczmarek
Details
Proposed patch (1.05 KB, patch)
2011-03-01 22:26 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Another patch (1.06 KB, patch)
2011-03-01 23:00 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2011-03-01 22:20:47 UTC
Created attachment 3235 [details]
A screenshot illustrating the problem

If there are double quotes in title (but also if there were any in lccn, isbn, issn, author, dewey, subject) the nice toolbar with buttons (cattoolbar) in normal view and MARC view (in staff client) will not appear.  Instead there is a text list of options (cf. screenshot).

The reason is that the JavaScript function GetZ3950Terms called when constructing the buttons fails, which is because of additional quotes in strQuery.  The reason for this is that the C4::Search::z3950_search_args function does not escape quotes.

A simple workaround will be submitted shortly.

Regards,

Janusz
Comment 1 Janusz Kaczmarek 2011-03-01 22:26:45 UTC Comment hidden (obsolete)
Comment 2 Janusz Kaczmarek 2011-03-01 23:00:47 UTC
Created attachment 3237 [details] [review]
Another patch

Another possible fix inspired by Paul Poulain.

J.
Comment 3 Katrin Fischer 2011-03-14 06:22:21 UTC
Patch work for me. Signed off.
Comment 4 Chris Cormack 2011-03-14 08:02:27 UTC
Pushed please test and mark resolved