Bug 5867 - "Hold filled" notice not sent by email if the user has its email address in a field other than "email"
Summary: "Hold filled" notice not sent by email if the user has its email address in a...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement
Assignee: Frédérick Capovilla
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-15 15:42 UTC by Frédérick Capovilla
Modified: 2012-10-25 23:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
[PATCH] Improved the email checking when sending "Hold filled" notices. (1.76 KB, patch)
2011-03-15 15:42 UTC, Frédérick Capovilla
Details | Diff | Splinter Review
Bug 5867 : Improved the email checking when sending "Hold filled" notices. (1.89 KB, patch)
2011-05-30 10:42 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Frédérick Capovilla 2011-03-15 15:42:37 UTC Comment hidden (obsolete)
Comment 1 Chris Cormack 2011-05-30 10:42:19 UTC
Created attachment 4302 [details] [review]
Bug 5867 : Improved the email checking when sending "Hold filled" notices.

The subroutine for sending HOLD and HOLD_PRINT notices only checked the
"email" field of the borrowers table and didn't check the value of the
AutoEmailPrimaryAddress preference. With this patch, "Hold filled"
notices can now be sent using the other email addresses of the member.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5867
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 2 Chris Cormack 2011-05-30 10:43:14 UTC
Signed off patch attached
Comment 3 Ian Walls 2011-07-14 22:41:15 UTC
Easy patch to read, uses existing subroutines correctly.  Marking as Passed QA
Comment 4 Chris Cormack 2011-07-14 23:11:35 UTC
Pushed, please test