Bug 5914 - BuildUnimarcHierarchies can go into an infinite loop in certain conditions
Summary: BuildUnimarcHierarchies can go into an infinite loop in certain conditions
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) major (vote)
Assignee: Henri-Damien LAURENT
QA Contact: Bugs List
URL:
Keywords:
Depends on: 5926
Blocks: 5581
  Show dependency treegraph
 
Reported: 2011-03-21 02:52 UTC by Chris Cormack
Modified: 2012-10-25 23:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (2.16 KB, patch)
2011-03-21 02:53 UTC, Chris Cormack
Details | Diff | Splinter Review
Replacement patch (4.45 KB, patch)
2011-03-21 22:36 UTC, Chris Cormack
Details | Diff | Splinter Review
Replacement patch (4.57 KB, patch)
2011-04-04 14:57 UTC, Stéphane Delaune
Details | Diff | Splinter Review
Replacement patch (4.57 KB, patch)
2011-04-05 08:47 UTC, Stéphane Delaune
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2011-03-21 02:52:06 UTC
When referenced authority in 5XX$3 would be the same as the current authid, the script would get into infinite loop
Comment 1 Chris Cormack 2011-03-21 02:53:20 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2011-03-21 22:36:27 UTC Comment hidden (obsolete)
Comment 3 Julian Maurice 2011-03-22 11:16:15 UTC
I have an error:

Undefined subroutine &C4::AuthoritiesMarc::_get_authid_subfield called at /home/julian/koha/versions/koha-community-git/C4/AuthoritiesMarc.pm line 1134.
Comment 4 Julian Maurice 2011-03-22 13:55:19 UTC
(In reply to comment #3)
> I have an error:
> 
> Undefined subroutine &C4::AuthoritiesMarc::_get_authid_subfield called at
> /home/julian/koha/versions/koha-community-git/C4/AuthoritiesMarc.pm line 1134.

_get_authid_subfield is introduced by bug 5926.
Comment 5 Stéphane Delaune 2011-04-04 14:57:31 UTC Comment hidden (obsolete)
Comment 6 Stéphane Delaune 2011-04-05 08:47:58 UTC
Created attachment 3651 [details] [review]
Replacement patch

It's the same patch than 3637, but I forgot to define the others as obsoletes
Comment 7 Chris Cormack 2011-04-06 03:36:20 UTC
Pushed, please test