Created attachment 3377 [details] [review] Proposed patch
Created attachment 3396 [details] 'Edit' link After applying the patch, I still see the "Edit" link (see attached screenshot). I think we can completely hide the authorities toolbar to users who don't have permissions, since they can't use any of the buttons it provides.
This bug is mentioned in: Bug 5916 : (MT #2685) don't show authority edition menu http://lists.koha-community.org/pipermail/koha-patches/2011-March/014157.html
Created attachment 5311 [details] [review] proposed patch (updated) The proposed patch was for H::T. As the file affected was .inc, that also exist for T::T, it was still applying, but no more working. This patch has been updated for T::T (+ few reindenting fixed + javascript variable put into the IF) I tested successfully this patch, please sign-off
it's not an enh, but a minor bugfix and back to "need signoff"
After applying this patch I still see edit authority on this page: cgi-bin/koha/authorities/auth_finder.pl?op=do_search&type=intranet&index=tag_100_subfield_a_22862_738128&authtypecode=PERSO_NAME&marclist=mainmainentry&and_or=and&operator=contains&value_mainstr=k&marclist=mainentry&and_or=and&operator=contains&and_or=and&operator=contains&orderby=HeadingAsc I'm not sure where this patch was supposed to remove that link from because it's not clear from the patch description. Please let me know all the places to look when the updated patch is submitted.
Nicole: if you don't have the manage authority (editauthorities) permission the link is not displayed. Are you sure you've checked without superlibrarian and no editauthorities permission ?
Yup, The librarian I tested with had cataloging permissions and some circulation permissions but not editauthorities. I'll test again and get you a screenshot of the permissions my staff user has. Nicole
Created attachment 5337 [details] patron permissions I tested again with this patron.
Created attachment 5338 [details] able to edit authorities The link to edit authorities is still showing even though she doesn't have the right permissions. I tried in Firefox and Chrome.
Marking Failed QA based on comment 10.
*** This bug has been marked as a duplicate of bug 10888 ***