Bug 5918 - When AddPatronLists is set to "general" and EnhancedMessagingPreferences is set, messaging prefs not copied from defaults
Summary: When AddPatronLists is set to "general" and EnhancedMessagingPreferences is s...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) major (vote)
Assignee: Kyle M Hall
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-21 13:22 UTC by D Ruth Holloway
Modified: 2012-10-25 23:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 5918 : Use the default messaging preferences if the user does not select any (5.94 KB, patch)
2011-05-31 22:34 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 5918 : Use the default messaging preferences if the user does not select any (5.74 KB, patch)
2011-06-01 00:10 UTC, Jesse Weaver
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description D Ruth Holloway 2011-03-21 13:22:12 UTC
the reason here seems to be that, in memberentry.pl, the Enhanced Preferences form is populated by data from the categorycode. However, when a new form is created using AddPatronLists as "general", no categorycode exists at that point, so the form is not populated.  

It would probably be a good idea to unset "setting_messaging_prefs" and/or perform some other checking to see if--on save--we need to fetch in the default preferences on a new borrower.

Ideas welcome.
Comment 1 Chris Cormack 2011-05-31 22:34:49 UTC
Created attachment 4322 [details] [review]
Bug 5918 : Use the default messaging preferences if the user does not select any
Comment 2 Jesse Weaver 2011-06-01 00:10:52 UTC
Created attachment 4323 [details] [review]
Bug 5918 : Use the default messaging preferences if the user does not select any

Signed-off-by: Jesse Weaver <pianohacker@gmail.com>
Comment 3 Ian Walls 2011-06-01 14:23:44 UTC
Tested and confirmed, marking as Passed QA
Comment 4 Chris Cormack 2011-06-01 21:19:40 UTC
Pushed to master, please test